Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[WIP] Move to pull-streams #440

Merged
merged 1 commit into from
Sep 9, 2016
Merged

[WIP] Move to pull-streams #440

merged 1 commit into from
Sep 9, 2016

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Aug 25, 2016 •
edited
Loading

  • Migrate the repo under test/go-ipfs-repo to the latest version of go-ipfs.

Tests Passing

  • Core
    • both
      • bitswap
      • block
      • bootstrap
      • config
      • files
      • generic
      • object
      • init
    • Node
      • init
      • swarm
    • Browser
      • bitswap
      • everything else
  • http
    • bitswap
    • block
    • bootstrap
    • config
    • files
    • id
    • object
    • repo
    • swarm
    • version
  • cli
    • bitswap
    • block
    • bootstrap
    • commands
    • config
    • bootstrap
    • files
    • id
    • object
    • swarm

Ref #403

@dignifiedquire
Copy link
Member Author

It looks like the swarm tests are not passing due to secio. Next step, test secio better and fix any issues with it + interop with go.

@dignifiedquire
Copy link
Member Author

I finally have the swarm tests passing. It seems there is something strange going on on the connection between nodes which results in the bitwap tests not passing. Other than those, only some smaller details in the files api need to be ironed out :)

@dignifiedquire dignifiedquire mentioned this pull request Sep 5, 2016
Closed
28 tasks
@dignifiedquire
Copy link
Member Author

bitswap tests pass with all new bug fixes in place :)

@daviddias
Copy link
Member

@dignifiedquire so, it is only missing the files tests? :D

daviddias
daviddias reviewed Sep 7, 2016
View reviewed changes
package.json
"pull-file": "^0.5.0",
"pull-paramap": "^1.1.6",
"pull-stream": "^3.4.3",
"pull-stream-to-stream": "^1.3.1",
Copy link
Member

@daviddias daviddias Sep 7, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's make sure to update it to latest

@dignifiedquire
Copy link
Member Author

pretty much only a single file test is failing at this point. Which is only due to the to node stream conversions

@daviddias
Copy link
Member

@dignifiedquire could you describe it more?

@dignifiedquire
Copy link
Member Author

The get directory test fails due to the content stream of one nested file not ending properly for some reason. I haven't tracked down where exactly it is failing.

@dignifiedquire
Copy link
Member Author

With the latest version I finally have them file tests passing when using pull-stream/pull-stream-to-stream#5

@dignifiedquire dignifiedquire mentioned this pull request Sep 9, 2016
Merged
@dignifiedquire
Copy link
Member Author

All tests passing locally with ipfs-inactive/interface-js-ipfs-core#70 🎉

@daviddias daviddias merged commit 1c64247 into master Sep 9, 2016
@daviddias daviddias deleted the pull branch September 9, 2016 13:59
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
@Stebalien @alanshaw
fix: don't expect ipfs to preserve a leading slash (ipfs#440)
d3ad40b 
Go-ipfs now normalizes paths before adding files. This will:

* remove any leading slashes.
* remove any `/./` components.
* normalize any `/../` components.

That breaks this test which assumes that paths are returned _exactly_ as
specified.
This was referenced Aug 3, 2023
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@daviddias daviddias

Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dignifiedquire @daviddias