Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat/awesome dag-pb #625

Merged
merged 11 commits into from
Nov 26, 2016
Merged

feat/awesome dag-pb #625

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
12325a2
chore: update deps
daviddias Nov 24, 2016
db550a1
feat(core): migrate to awesome dag-pb
daviddias Nov 24, 2016
265a77a
feat(swarm): update swarm.peers to new api
dignifiedquire Nov 17, 2016
3fa1438
chore: update deps
daviddias Nov 17, 2016
1132f33
Merge pull request #600 from ipfs/new-swarm-peers
daviddias Nov 24, 2016
ca9935f
feat(http): migrate to awesome dag-pb
daviddias Nov 24, 2016
3bb3ba8
feat(cli): migrate to awesome-dag-pb
daviddias Nov 25, 2016
698f708
fix: apply CR
daviddias Nov 25, 2016
7fad4d8
fix: addLink and rmLink
daviddias Nov 25, 2016
443dd9e
fix(lint): use eslint directly
daviddias Nov 25, 2016
20e3d2e
fix(lint): install missing plugin
dignifiedquire Nov 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"npm": ">=3.0.0"
},
"scripts": {
"lint": "aegir-lint",
"lint": "eslint -c node_modules/aegir/config/eslintrc.yml src test",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting is fine, it is just aegir-lint that is being mysterious. This is a known problem by @dignifiedquire, needs to be more investigated.

thanks @victorbjelkholm for the tip! :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, but lets try to not actually merge this code, will see if I can figure this out on the aegir side

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Q. Why did it pass with eslint -c node_modules/aegir/config/eslintrc.yml src test?
  • A. It did not lint examples
  • Q. Why does aegir fail silently?
  • A. An eslint plugin being used in the examples folder: https://github.com/ipfs/js-ipfs/blob/master/examples/bundle-webpack/.eslintrc#L9 was missing, which resulted in an exit from eslint. Running eslint on the command line will print a custom error message for this, which does not happen when using gulp-eslint.
  • Q. Why does linting still fail?
  • A. Because the examples were never properly fixed.

"coverage": "gulp coverage",
"test": "gulp test",
"test:node": "gulp test:node",
Expand Down