Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: ipfs.id does not double append ipfs/<id> anymore #732

Merged
merged 1 commit into from
Jan 28, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions src/core/components/id.js
Original file line number Diff line number Diff line change
@@ -1,30 +1,27 @@
'use strict'

const promisify = require('promisify-es6')
const mafmt = require('mafmt')

module.exports = function id (self) {
return promisify((opts, callback) => {
if (typeof opts === 'function') {
callback = opts
opts = {}
}
if (!self._peerInfo) { // because of split second warmup
setTimeout(ready, 100)
} else {
ready()
}

function ready () {
callback(null, {
id: self._peerInfo.id.toB58String(),
publicKey: self._peerInfo.id.pubKey.bytes.toString('base64'),
addresses: self._peerInfo.multiaddrs.map((ma) => {
const addr = ma.toString() + '/ipfs/' + self._peerInfo.id.toB58String()
return addr
}).sort(),
agentVersion: 'js-ipfs',
protocolVersion: '9000'
})
}
setImmediate(() => callback(null, {
id: self._peerInfo.id.toB58String(),
publicKey: self._peerInfo.id.pubKey.bytes.toString('base64'),
addresses: self._peerInfo.multiaddrs.map((ma) => {
if (mafmt.IPFS.matches(ma)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we should've extract this logic and put it under test as well, just to be sure... Sorry for the late notice 📦

return ma.toString()
} else {
return ma.toString() + '/ipfs/' + self._peerInfo.id.toB58String()
}
}).sort(),
agentVersion: 'js-ipfs',
protocolVersion: '9000'
}))
})
}