This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: no need anymore to append ipfs/Qmhash to webrtc-star multiaddrs #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this not needed anymore for all addresses? |
daviddias
commented
Mar 15, 2017
| self._peerInfo.id.toB58String()) | ||
| } | ||
|
|
||
| self._peerInfo.multiaddr.add(ma) |
There was a problem hiding this comment.
@dignifiedquire see here: I append it if it is not there.
|
Considering adding webrtc as a default transport to the browser. |
daviddias
force-pushed
the
feat/webrtc-without-id
branch
from
fb18703
to
a77ae3c
Compare
This was referenced Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of those simple things that will make everyone's life so much easier