This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
runtime specific things - bring libp2p bundles here #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgte
reviewed
Jul 3, 2017
src/core/components/libp2p.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| 'use strict' | |||
|
|
|||
| const Node = require('libp2p-ipfs-nodejs') | |||
| const Node = require('../runtime/libp2p-nodejs') | |||
There was a problem hiding this comment.
Perhaps add a comment before explaining that this will be switched to file x in the browser?
pgte
reviewed
Jul 3, 2017
| } | ||
| } | ||
|
|
||
| class Node extends libp2p { |
There was a problem hiding this comment.
This file has a lot in common with it's browser version. Perhaps we could reduce this to a declarative config and not need to declare a class here?
There was a problem hiding this comment.
True, at the same time it serves the purpose of being an awesome template for others to c&p
pgte
reviewed
Jul 3, 2017
| @@ -32,6 +32,7 @@ module.exports = (ctl) => { | |||
| ctl.bootstrap.add({ default: true }, (err, res) => { | |||
| expect(err).to.not.exist() | |||
| peers = res.Peers | |||
| console.log(res) | |||
pgte
suggested changes
Jul 3, 2017
dryajov
pushed a commit
that referenced
this pull request
Sep 1, 2017
* feat: move runtime dependent configs (repo and config) to runtime folder * feat: bring libp2p bundles to this repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following: libp2p/js-libp2p#92
Moving bundles and tests from libp2p-ipfs-* to js-libp2p