This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Adding Gateway , based on harshjv PR #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ya7ya in order to make collaboration easier, I created a new branch in the main repo and merged @harshjv PR to it so that you can target your PR to the same branch. This is important because we want to ensure we preserve commit history (in this case, @harshjv initial contributions). Please rebase the branch onto your PR so that there are no merge conflicts. I'll CR then :) |
License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
|
@diasdavid I rebased the |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
This was referenced Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, This is a gateway implementation based on PR #698 by harshjv . with the modifications required to accept it as mentioned in PR #698 .
Changes made:
@diasdavid Please let me know if this is good or if there are any modifications required to get this PR merged. Thank you for your help.