This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
clean up, remove commented out lines. #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's keep it as http then.
These tests are designed to work over the HTTP-API. Testing the gateway requires a new set of tests. |
|
Yes the gateway requires different tests. I removed the commented out blocks. and I will try to add more tests beside the ones in |
daviddias
reviewed
Aug 31, 2017
test/gateway/index.js
Outdated
| @@ -40,16 +40,4 @@ describe('HTTP GATEWAY', () => { | |||
| fs.readdirSync(path.join(__dirname, '/spec')) | |||
| .forEach((file) => require('./spec/' + file)(http)) | |||
| }) | |||
There was a problem hiding this comment.
@ya7ya there are not "gateway spec tests" you probably just have "tests" :)
There was a problem hiding this comment.
@diasdavid ma bad, I'll fix that,
I'm looking at the gateway_test.go to try to port these tests to js-ipfs .
There was a problem hiding this comment.
awesome! That's perfect @ya7ya :)
ya7ya
added a commit
to ya7ya/js-ipfs
that referenced
this pull request
Sep 2, 2017
* clean up, remove commented out lines. * cleaning code, removing commented out blocks. * gateway initial tests.
daviddias
pushed a commit
that referenced
this pull request
Sep 5, 2017
* feat: add gateway route to daemon * feat: adding Gateway endeavour - improve codebase * clean up, remove commented out lines. (#971) * clean up, remove commented out lines. * cleaning code, removing commented out blocks. * gateway initial tests. * clean up , working tests on node v8.4.0 License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * fix using js-ipfs-repo in gateway tests. License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * Using unix-fs to detect dirs, replacing object.get with DAG.get, CID checks License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * rename checkHash -> checkCID License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * gateway tests: init a fresh repo
daviddias
pushed a commit
that referenced
this pull request
Sep 6, 2017
* feat: add gateway route to daemon * feat: adding Gateway endeavour - improve codebase * clean up, remove commented out lines. (#971) * clean up, remove commented out lines. * cleaning code, removing commented out blocks. * gateway initial tests. * clean up , working tests on node v8.4.0 License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * fix using js-ipfs-repo in gateway tests. License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * Using unix-fs to detect dirs, replacing object.get with DAG.get, CID checks License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * rename checkHash -> checkCID License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * gateway tests: init a fresh repo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code cleanup as requested in #968
Changes
httptodaemon.(In
go-ipfsthe module is still calledhttpthough.)interfaceandipfs-over-apiTests.(they're enabled in
tests/http-apibut nottest/gatewayso there won't be duplicate tests)@diasdavid Please Let me know if the 2 remaining points are greenlit and i'll push the edits ASAP. Thanks.