fix: Return node only after go-ipfs daemon is ready #150
Conversation
|
|
||
| if (readyMatch) { | ||
| callback(null, this.api) | ||
| } |
There was a problem hiding this comment.
str.match is non blocking, if you found that bug happening, it means that the output was captured before go-ipfs had written everything. I believe that this doesn't solve the issue (🕸🕷), only silences it by not calling the callback with an undefined parameter. Let's add a else to callback with a error signalling that the daemon was not found ready.
There was a problem hiding this comment.
Yeah, this part was getting called multiple times (twice in this case), first with "API listening..." and then with "Gateway (readonly) listening...\nDaemon is ready". Not sure why or if that's the intended behaviour, but adding an else and an error callback will just make it fail always (from user's perspective).
@dignifiedquire I believe you refactored the exec code last time, any ideas here?
There was a problem hiding this comment.
You can use http://npmjs.org/once
daviddias
added
status/ready
|
Awesome! Thank you for slaying the 🐉 😄 |
Testing new ipfsd-ctl with Orbit I found a bug where the node is returned before the gateway address has been received and patched to the returned API. Ie. gatewayAddr was undefined.
This PR changes the callback logic so that we listen for "Daemon is ready" stdout from go-ipfs and only then return. Previously we returned when stdout matched "API listening...".