-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaces path to .asar.unpacked if cmd includes .asar/node_modules #155
Changes from 9 commits
e9ac8b0
c641866
03ea8d5
60fa938
a6b1347
9f53ce8
1b9dcf8
279f58f
3fc9347
135dca4
46c422e
92841df
5190a48
32e8200
f3e49d5
0510863
d74578b
d1a7bdf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
environment: | ||
matrix: | ||
- nodejs_version: "6" | ||
- nodejs_version: "8" | ||
|
||
# cache: | ||
# - node_modules | ||
|
||
platform: | ||
- x64 | ||
|
||
install: | ||
- ps: Install-Product node $env:nodejs_version $env:platform | ||
- npm install | ||
|
||
test_script: | ||
- node --version | ||
- npm --version | ||
- npm test | ||
|
||
build: off | ||
|
||
version: "{build}" |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,7 @@ describe('ipfs executable path', () => { | |
Node = require('../src/node.js') | ||
var node = new Node() | ||
expect(node.exec) | ||
.to.eql('/tmp/ipfsd-ctl-test/node_modules/go-ipfs-dep/go-ipfs/ipfs') | ||
.to.eql(path.normalize('/tmp/ipfsd-ctl-test/node_modules/go-ipfs-dep/go-ipfs/ipfs')) | ||
rimraf('/tmp/ipfsd-ctl-test', done) | ||
}) | ||
}) | ||
|
@@ -58,7 +58,7 @@ describe('ipfs executable path', () => { | |
expect( | ||
node.exec | ||
).to.be.eql( | ||
'/tmp/ipfsd-ctl-test/node_modules/ipfsd-ctl/node_modules/go-ipfs-dep/go-ipfs/ipfs' | ||
path.normalize('/tmp/ipfsd-ctl-test/node_modules/ipfsd-ctl/node_modules/go-ipfs-dep/go-ipfs/ipfs') | ||
) | ||
rimraf('/tmp/ipfsd-ctl-test', done) | ||
}) | ||
|
@@ -390,10 +390,17 @@ describe('daemons', () => { | |
if (err) throw err | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. see: #155 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here is an example: https://github.com/ipfs/npm-go-ipfs-dep/blob/master/src/index.js#L47-L60 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As it is a temporary skip, is it ok if I just There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't get https://github.com/ipfs/npm-go-ipfs-dep/blob/master/src/index.js#L47-L60 sorry!! :( it also depends on another module (go-platform) and file https://github.com/ipfs/npm-go-ipfs-dep/blob/master/src/check-support.js |
||
|
||
const added = res[res.length - 1] | ||
expect(res.length).to.equal(2) | ||
expect(added).to.have.property('path', 'fixtures') | ||
expect(added).to.have.property( | ||
'hash', | ||
'QmXkiTdnfRJjiQREtF5dWf2X4V9awNHQSn9YGofwVY4qUU' | ||
) | ||
expect(res[0]).to.have.property('path', 'fixtures/test.txt') | ||
expect(res[0]).to.have.property( | ||
'hash', | ||
'Qmf412jQZiuVUtdgnB36FXFX7xg5V6KEbSJ4dpQuhkLyfD' | ||
) | ||
done() | ||
}) | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this to the README too? It is fine to leave it here, but I want to make sure it this note is searchable and linkable to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure