Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try with a different port #209

Closed
wants to merge 1 commit into from
Closed

fix: try with a different port #209

wants to merge 1 commit into from

Conversation

daviddias
Copy link
Member

No description provided.

@ghost ghost assigned daviddias Feb 22, 2018
@ghost ghost added the status/in-progress In progress label Feb 22, 2018
@victorb
Copy link
Member

victorb commented Feb 22, 2018

👎 not a proper fix as this might break in the future too. We cannot make assumptions about free ports (but I bet you already knew this). As mentioned elsewhere, I'm working on fixing this right now.

@daviddias
Copy link
Member Author

daviddias commented Feb 22, 2018

@victorbjelkholm I'm testing you hypothesis from #206 (comment)

I claim that it isn't the port but rather the server that is not being closed properly. Making the port random generated would just hide the problem for now, but it would create issues for users.

@daviddias
Copy link
Member Author

Alright, seems that indeed Mac OS uses port 9999 for something, so the server is being closed properly.

image

👌🏽

@daviddias daviddias closed this Feb 22, 2018
@ghost ghost removed the status/in-progress In progress label Feb 22, 2018
@victorb
Copy link
Member

victorb commented Feb 22, 2018

Making the port random generated would just hide the problem for now, but it would create issues for users

The fix I'm working on doesn't involve ipfsd-ctl at all, just how ipfs/js-ipfs is using it.

@daviddias daviddias deleted the test-port branch February 22, 2018 10:32
@dryajov
Copy link
Member

dryajov commented Feb 22, 2018

I say we change the port to something else - the one here seems reasonable, 9999 seems too common and super easy to clash with. @diasdavid lets get this merged?

@victorb
Copy link
Member

victorb commented Feb 22, 2018

Silly but 4737 would mean IPFS on a T9 keyboard (and US phonenumbers somehow?). Would be a good port and easy to remember if you used to send sms's a couple of years ago 🎉

@dryajov dryajov mentioned this pull request Feb 22, 2018
@daviddias daviddias restored the test-port branch February 23, 2018 08:10
@daviddias
Copy link
Member Author

#211

@daviddias
Copy link
Member Author

@victorbjelkholm that one would be good for the ipfs daemon default listening port :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants