Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove option normalisation #454

Merged
merged 6 commits into from
Feb 10, 2020
Merged

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jan 31, 2020

There are just too many options, too many variables and too many different calling contexts so let's get the user to be explicit about how they intend to use the module rather than try to second guess them.

Also, allow the user to specify opts/overrides to the ipfsd server's use of createFactory.

There are just too many options, to many variables and too many
different calling contexts so let's get the user to be explicit
about how they intend to use the module rather than try to
second guess them.
@achingbrain
Copy link
Member Author

achingbrain commented Jan 31, 2020

I can't say I've come across a lot of any instances where I need one implementation of ipfsModule or ipfsHttpModule in one place and then another somewhere else so it doesn't make a lot of sense to allow them as options to .spawn.

If there's then no danger of sending refs over a http connection maybe we can get rid of the whole path/ref thing and just pass refs in to createFactory?

@achingbrain
Copy link
Member Author

@hugomrdias any changes needed here?

@hugomrdias
Copy link
Member

agree lets remove ref/path.

can we remove the second param from findBin also?

@hugomrdias hugomrdias merged commit f1e5c82 into master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants