Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps #32

Merged
merged 2 commits into from
Dec 18, 2019
Merged

chore: update deps #32

merged 2 commits into from
Dec 18, 2019

Conversation

alanshaw
Copy link
Member

Currently has 1 failing test:

Screenshot 2019-12-18 at 00 04 20

Please can someone take a look?

@jacobheun
Copy link
Contributor

The failing test is due to a bug with decoding inline public keys. Opened a PR for peer-id, libp2p/js-peer-id#109, I verified this fixes the test.

@vasco-santos
Copy link
Member

vasco-santos commented Dec 18, 2019

Thanks @jacobheun

@alanshaw can you just fix the linting? I just released the new version of peer-id

@jacobheun
Copy link
Contributor

I went ahead and pushed the peer-id version update and removed the console log that was breaking lint to verify CI is good (and it is!). This should be gtg.

@vasco-santos vasco-santos merged commit 6152692 into master Dec 18, 2019
@alanshaw alanshaw deleted the chore/update-deps-20191218 branch December 18, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants