fix: remove bootstrap.clear() and bootstrap.reset()

ipfs · Jan 4, 2023 · 5537d46 · 5537d46
1 parent 0176418
commit 5537d46
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 169 deletions.
diff --git a/src/bootstrap/clear.js b/src/bootstrap/clear.js
diff --git a/src/bootstrap/index.js b/src/bootstrap/index.js
@@ -1,21 +1,14 @@
 import { createAdd } from './add.js'
-import { createClear } from './clear.js'
 import { createList } from './list.js'
-import { createReset } from './reset.js'
 import { createRm } from './rm.js'
 
 /**
  * @param {import('../types').Options} config
  */
 export function createBootstrap (config) {
   return {
-    /**
-     * TODO: Remove nonmatching bootstrap subcommands https://github.com/ipfs/js-kubo-rpc-client/issues/96
-     */
     add: createAdd(config),
-    clear: createClear(config),
     list: createList(config),
-    reset: createReset(config),
     rm: createRm(config)
   }
 }
diff --git a/src/bootstrap/reset.js b/src/bootstrap/reset.js
diff --git a/src/types.ts b/src/types.ts
@@ -55,10 +55,11 @@ interface KuboRpcClientConfigApi extends Omit<OldRpcClientConfigApi, 'profiles'>
   profiles: Omit<OldRpcClientConfigApi['profiles'], 'list'>
 }
 
-export interface KuboRpcClientApi extends Omit<IPFS<HTTPClientExtraOptions>, 'files' | 'bitswap' | 'config'> {
+export interface KuboRpcClientApi extends Omit<IPFS<HTTPClientExtraOptions>, 'files' | 'bitswap' | 'config' | 'bootstrap'> {
   bitswap: Omit<IPFS<HTTPClientExtraOptions>['bitswap'], 'unwant'>
   config: KuboRpcClientConfigApi
   files: Omit<IPFS<HTTPClientExtraOptions>['files'], 'chmod' | 'touch'>
+  bootstrap: Omit<IPFS<HTTPClientExtraOptions>['bootstrap'], 'clear' | 'reset'>
 }
 
 export interface IPFSHTTPClient extends KuboRpcClientApi {

diff --git a/test/interface-tests/src/bootstrap/add.js b/test/interface-tests/src/bootstrap/add.js
@@ -46,8 +46,6 @@ export function testAdd (factory, options) {
     })
 
     it('should prevent duplicate inserts of bootstrap peers', async () => {
-      await ipfs.bootstrap.clear()
-
       const added = await ipfs.bootstrap.add(validIp4)
       expect(added).to.have.property('Peers').that.deep.equals([validIp4])
 

diff --git a/test/interface-tests/src/bootstrap/clear.js b/test/interface-tests/src/bootstrap/clear.js
diff --git a/test/interface-tests/src/bootstrap/index.js b/test/interface-tests/src/bootstrap/index.js
@@ -1,15 +1,11 @@
 import { createSuite } from '../utils/suite.js'
 import { testAdd } from './add.js'
-import { testClear } from './clear.js'
 import { testList } from './list.js'
-import { testReset } from './reset.js'
 import { testRm } from './rm.js'
 
 const tests = {
   add: testAdd,
-  clear: testClear,
   list: testList,
-  reset: testReset,
   rm: testRm
 }
 

diff --git a/test/interface-tests/src/bootstrap/reset.js b/test/interface-tests/src/bootstrap/reset.js