Skip to content

Commit

Permalink
make test now runs expensive tests.
Browse files Browse the repository at this point in the history
We use make test as the measure of correctness.
This laxity has let bugs creep into several systems.
This commit changes our target to always run expensive
tests, unless one specifically runs `make test_short`

(we would do well to remove most if not all timing--
that's usually what makes tests take a long time.)
  • Loading branch information
jbenet committed Jan 4, 2015
1 parent d7b0c74 commit 21e2b9b
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,25 @@ vendor: godep
install:
cd cmd/ipfs && go install

test: test_go test_sharness
##############################################################
# tests targets

test: test_expensive

test_short: test_go_short test_sharness_short

test_expensive: test_go_expensive test_sharness_expensive

test_docker:
cd dockertest/ && make

test_go:
test_go_short:
go test -test.short ./...

test_go_expensive:
go test ./...

test_sharness:
test_sharness_short:
cd test/ && make

test_sharness_expensive:
Expand Down

1 comment on commit 21e2b9b

@jbenet
Copy link
Member Author

@jbenet jbenet commented on 21e2b9b Jan 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we have to consciously deceive ourselves with make test_short

Please sign in to comment.