Skip to content

Commit

Permalink
Revert "wait for the nodes to fully stop"
Browse files Browse the repository at this point in the history
WIP: making sure this is actually the issue.

This reverts commit 202cedd.
  • Loading branch information
Stebalien committed Jul 30, 2018
1 parent a920136 commit 429b3c4
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 10 deletions.
6 changes: 0 additions & 6 deletions test/sharness/lib/iptb-lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,3 @@ startup_cluster() {
'
done
}

iptb_wait_stop() {
while ! iptb for-each sh -c '! { test -e "$IPFS_PATH/repo.lock" && fuser -f "$IPFS_PATH/repo.lock" >/dev/null; }'; do
go-sleep 10ms
done
}
2 changes: 1 addition & 1 deletion test/sharness/t0125-twonode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ run_advanced_test() {
'

test_expect_success "shut down nodes" '
iptb stop && iptb_wait_stop
iptb stop
'
}

Expand Down
4 changes: 2 additions & 2 deletions test/sharness/t0130-multinode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ run_basic_test() {
run_single_file_test

test_expect_success "shut down nodes" '
iptb stop && iptb_wait_stop
iptb stop
'
}

Expand All @@ -79,7 +79,7 @@ run_advanced_test() {
run_random_dir_test

test_expect_success "shut down nodes" '
iptb stop && iptb_wait_stop ||
iptb stop ||
test_fsh tail -n +1 .iptb/*/daemon.std*
'
}
Expand Down
1 change: 0 additions & 1 deletion test/sharness/t0182-circuit-relay.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ test_expect_success 'configure EnableRelayHop in relay node' '

test_expect_success 'restart nodes' '
iptb stop &&
iptb_wait_stop &&
iptb start --args --routing=none
'

Expand Down

1 comment on commit 429b3c4

@GitCop
Copy link

@GitCop GitCop commented on 429b3c4 Jul 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were the following issues with your Pull Request

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

Please sign in to comment.