fix check_go_path when it has spaces in it

fixes #5260
ipfs · Jul 19, 2018 · 6a7f724 · 6a7f724 · GitCop · Jul 19, 2018
1 parent 6f140d2
commit 6a7f724
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/bin/check_go_path b/bin/check_go_path
@@ -1,19 +1,18 @@
 #!/bin/sh
 
-PWD=$1
+set -e
 
-if [ -z "$PWD" ]; then
-	echo "must pass in your current working directory"
-	exit 1
-fi
+PKG="$1"
 
-while [ ${#} -gt 1 ]; do
-	if [ "$PWD" = "$2" ]; then
-		exit 0
-	fi
-	shift
+PWD="$(realpath "$(pwd)")"
+GOPATH="$(go env GOPATH)"
+
+for p in IFS=: "${GOPATH}"; do
+    if [ "$PWD" = "$(realpath "$p")/src/$PKG" ]; then
+        exit 0
+    fi
 done
 
 echo "go-ipfs must be built from within your \$GOPATH directory."
-echo "expected within '$(go env GOPATH)' but got '$PWD'"
+echo "expected within '$GOPATH' but got '$PWD'"
 exit 1
diff --git a/mk/golang.mk b/mk/golang.mk
@@ -66,7 +66,7 @@ check_go_version:
 DEPS_GO += check_go_version
 
 check_go_path:
-	bin/check_go_path $(realpath $(shell pwd)) $(realpath $(addsuffix /src/github.com/ipfs/go-ipfs,$(subst $(PATH_SEP),$(space),$(GOPATH))))
+	GOPATH="$(GOPATH)" bin/check_go_path github.com/ipfs/go-ipfs
 .PHONY: check_go_path
 DEPS_GO += check_go_path