Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go fmt and other things #17

Closed
jbenet opened this issue Jul 30, 2014 · 3 comments
Closed

go fmt and other things #17

jbenet opened this issue Jul 30, 2014 · 3 comments

Comments

@jbenet
Copy link
Member

jbenet commented Jul 30, 2014

I want to make sure all code pushed is run through go fmt. We probably want:

  • a git pre commit hook
  • a github integration that checks PRs (go fmt, go test)

This post (http://peter.bourgon.org/go-in-production/) also recommends:

on Save: go fmt (or goimports)
on Build: go vet, golint, and maybe go test
on Deploy: go test -tags=integration

@jbenet
Copy link
Member Author

jbenet commented Jul 30, 2014

cc @sqs thoughts?

@sqs
Copy link
Contributor

sqs commented Jul 30, 2014

Travis-CI is great for go test. (https://github.com/sourcegraph/srclib/blob/a672df5a0adaa762a66db579f7d13fa3aa6523e3/.travis.yml)

As for go fmt, in my experience 98% of Go contributors already enable it in their editor. But yeah, for accepting contributions, it's probably nice.

go vet/lint are not intended to be strictly adhered to in all cases, and there's no way of "ignoring" warnings, so those are probably best run manually or as optional steps.

@jbenet jbenet mentioned this issue Jul 30, 2014
jbenet added a commit that referenced this issue Jul 30, 2014
@jbenet
Copy link
Member Author

jbenet commented Jul 30, 2014

thanks @sqs ! i've added go test with Travis-CI, and go fmt to the readme. that should be good for now.

@jbenet jbenet closed this as completed Jul 30, 2014
ribasushi pushed a commit that referenced this issue Jul 4, 2021
Delete no longer used goHTTPPropagator
ribasushi pushed a commit that referenced this issue Jul 4, 2021
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
80 tasks
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
…orts

randomports: give user ability to init ipfs using random port for swarm.
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
…/profile/randomports

randomports: give user ability to init ipfs using random port for swarm.
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
…/profile/randomports

randomports: give user ability to init ipfs using random port for swarm.
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
…/profile/randomports

randomports: give user ability to init ipfs using random port for swarm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants