did cat lose the progress bar?

[jbenet]

I'm not seeing it

> ipfs cat QmXipyrjt2Vzjg2vV7uhgCi8GNEFhrEdXrirtDcYhqGGEc >r3

cc @rht

[jbenet]

QmXipyrjt2Vzjg2vV7uhgCi8GNEFhrEdXrirtDcYhqGGEc is ~200MB of randomness.

[rht]

The err happens only when daemon is on
Error: read tcp 127.0.0.1:53124->127.0.0.1:5001: read: connection reset by peer.
When offline, sometimes it shows progressbar when it is slow enough.

[jbenet]

isn't that error different? the cat actually completes

[jbenet]

And, are you getting cat progressbar at all on daemon now? it used to be there-- do we need to bisect this?

[rht]

No, the cat err when daemon that it doesn't complete. Bisecting.

[rht]

Found a bug: coreunix.Cat should have ctx as arg.

[rht]

At least for the connection reset by peer err:

a7e50f1 is the first bad commit

commit a7e50f1fbc5a58963a1b1e462575249de61540f1
Author: Jeromy <jeromyj@gmail.com>
Date:   Fri Jul 24 17:41:59 2015 -0700

    implement http trailers for errors after headers are sent

    refactor http handler and copyChunks to get this all to work correctly
    License: MIT
    Signed-off-by: Jeromy <jeromyj@gmail.com>

[rht]

a7e50f1

[whyrusleeping]

yeah, the connection reset by beer is a result of us not properly handling trailers, and will be fixed by #1621 when we make go1.5 a requirement.

[rht]

What would be the fix in the mean time? Offline cat?

[rht]

Can be closed?

[whyrusleeping]

it doesnt look like cat has a progress bar still... thats odd

[rht]

Bisecting, 814f437 is the latest good commit. The first bad commit is still the same as the pointed out in #1795 (comment).

[rht]

One likely cause: a7e50f1#diff-ceb40d01c16a02936d808eb855ea499bR293 wraps outside of the progressbar reader.
Would it be clean to use channel (just as the one used in ipfs add)?

[jbenet]

fwiw, im not seeing the progressbar on add either. what happened?

cc @whyrusleeping

[jbenet]

and we should test that progress bar works so that this doesnt happen again

[daviddias]

Following @whyrusleeping's comment #736 (comment), we now have a progressbar, sometimes it takes time to appear when the dir is too large. Closing this one in favor of keeping progressbar enhancements discussion on #736