Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t0080 has bad gc test #2906

Closed
whyrusleeping opened this issue Jun 25, 2016 · 1 comment
Closed

t0080 has bad gc test #2906

whyrusleeping opened this issue Jun 25, 2016 · 1 comment
Labels
status/in-progress In progress topic/test failure Topic test failure
Milestone
ipfs-0.4.3-rc1

Comments

@whyrusleeping
Copy link
Member

Type: test failure
Area: repo sharness tests
Priority: P1

Description:
in t0080-repo.sh, there is a test (currently test_expect_failure) that checks the size of a repo before and after a gc. This is occasionally faulty because the daemon is running during this and will sometimes write random bits of data to the datastore, thus changing the observed size. We should either run this test with the daemon offline, or find a better way to measure
@whyrusleeping whyrusleeping added the topic/test failure Topic test failure label Jun 25, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Jun 25, 2016

As we have --offline flag now it should be easy.

Kubuxu added a commit that referenced this issue Jun 25, 2016
@Kubuxu
test: Run t0080-repo test offline
c55b3ec 
Resolves #2906

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu mentioned this issue Jun 25, 2016
Merged
@Kubuxu Kubuxu added this to the ipfs-0.4.3 milestone Jun 28, 2016
@Kubuxu Kubuxu added the status/in-progress In progress label Jun 29, 2016
whyrusleeping pushed a commit that referenced this issue Jul 2, 2016
@Kubuxu @whyrusleeping
test: Run t0080-repo test offline
e446b3d 
Resolves #2906

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status/in-progress In progress topic/test failure Topic test failure
Projects
None yet
Milestone
ipfs-0.4.3-rc1
Development

No branches or pull requests
2 participants
@whyrusleeping @Kubuxu