Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message when shutting down ipfs daemon #4055

Closed
JayBrown opened this issue Jul 11, 2017 · 10 comments · Fixed by #5322
Closed

Error message when shutting down ipfs daemon #4055

JayBrown opened this issue Jul 11, 2017 · 10 comments · Fixed by #5322
Assignees
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) topic/test failure Topic test failure

Comments

@JayBrown
Copy link

Version information:

go-ipfs version: 0.4.10-4679f80
Repo version: 5
System version: amd64/darwin
Golang version: go1.8.3

possible bug

Type:

error message without any noticeable error

Severity:

very low

Description:

I ran ipfs shutdown on the daemon, which had been started with --writable, and received the following error message (in the second terminal, not in the daemon's terminal).

Error: Post http://127.0.0.1:5001/api/v0/shutdown?encoding=json&stream-channels=true: EOF

Daemon shutdown worked nonetheless.

@whyrusleeping
Copy link
Member

This same issue is causing random test failures in CI. Lets figure it out asap

@whyrusleeping whyrusleeping added kind/bug A bug in existing code (including security flaws) topic/test failure Topic test failure help wanted Seeking public contribution on this issue labels Jul 12, 2017
@sherodtaylor
Copy link

sherodtaylor commented Aug 9, 2017

Still getting this issue. #4123

@whyrusleeping whyrusleeping added this to the Ipfs 0.4.12 milestone Aug 30, 2017
@Kubuxu Kubuxu modified the milestones: Ipfs 0.4.12, go-ipfs 0.4.13 Nov 6, 2017
@schomatis
Copy link
Contributor

@whyrusleeping Is this still an ongoing problem? I'm having trouble reproducing the error.

@Stebalien
Copy link
Member

I haven't seen it for a while but I don't know of anything we might have done to fix it (maybe updating the commands lib?).

@Kubuxu
Copy link
Member

Kubuxu commented Mar 14, 2018

@schomatis it was rare, usually daemon takes a sweet time to shut down and this happens only if it shuts down too fast. You can try running ipfs daemon --offline so it shuts down faster.

@Stebalien
Copy link
Member

It's still happening.

@schomatis
Copy link
Contributor

I'll take a look using @Kubuxu's advice.

@schomatis
Copy link
Contributor

I can't reproduce it. I've tried with combinations of the --offline and --writable flags, with a heavy add load to the daemon and without. @Stebalien in what conditions did you see it happening again?

@Stebalien
Copy link
Member

I just saw it on a random test on Jenkins. Unfortunately, I can't recall which test.

@Kubuxu
Copy link
Member

Kubuxu commented Mar 23, 2018

It happens quite frequently on Jenkins.

Stebalien added a commit that referenced this issue Jul 30, 2018
see: #4055

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jul 30, 2018
see: #4055

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jul 31, 2018
Using httpServer.Shutdown will:

1. Close the listener (preventing new connections).
2. Close each connection as outstanding requests finish.

This prevent us from shutting down before outstanding requests get a chance to
respond.

fixes #4055

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Jul 31, 2018
@ghost ghost added the status/in-progress In progress label Jul 31, 2018
@ghost ghost removed the status/in-progress In progress label Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) topic/test failure Topic test failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants