Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins config from repo? #510

Closed
jbenet opened this issue Jan 7, 2015 · 3 comments
Closed

jenkins config from repo? #510

jbenet opened this issue Jan 7, 2015 · 3 comments
Labels
kind/test Testing work

Comments

@jbenet
Copy link
Member

jbenet commented Jan 7, 2015

I think we should be able to configure jenkins from the repo (like travis). it's painful to have to go to a web service when something changes in the repo. Particularly problematic as things are in PR, as it will necessarily break.

cc @briantigerchow

@jbenet jbenet mentioned this issue Jan 7, 2015
@btc
Copy link
Contributor

btc commented Jan 10, 2015

You're completely right about this. I initially leaned toward on-Jenkins configuration to iterate more quickly and get it up and running without interfering with the go-ipfs repository.

edit:
Ideally, we'd want all tests to be executed using make tasks, yeah? If so, want 'em in the top-level Makefile (cautious of co-opting/polluting it).

just saw the comment in #511

re: #510 -- maybe we can keep the jenkins test scripts in test/jenkins/* (matching the name of the jenkins test) instead of in jenkins ui.

SGTM. Will assign this one to myself.

For full transparency...
Alternatively, there's https://github.com/groupon/DotCi. That plugin/suite makes Jenkins work a lot like Travis (declarative yaml). Dotci is opinionated such that we'd have to perform some non-trivial infrastructure reconfiguration. It is also incompatible with Slave swarms, so slave authentication would need to be handled differently. When I evaluated these trade-offs a few months ago, I the sheer number of concessions sufficiently unattractive. Just want to make all parties are aware the option exists.

@btc btc self-assigned this Jan 10, 2015
@jbenet
Copy link
Member Author

jbenet commented Jan 12, 2015

https://github.com/groupon/DotCi seems like the right idea -- a lot of the features they boast sound good -- but sounds like it's not going to work for us. Your call -- I don't have good knowledge on all the tradeoffs involved at all.

@jbenet jbenet added the kind/test Testing work label Mar 28, 2015
@jbenet jbenet unassigned btc Mar 30, 2015
@whyrusleeping
Copy link
Member

we use circleCI and travis and appeyor now, which are all configurable through config files in this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test Testing work
Projects
None yet
Development

No branches or pull requests

3 participants