Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local DHT put doesn't reject bad keys #5113

Closed
Stebalien opened this issue Jun 14, 2018 · 0 comments · Fixed by #5158
Closed

Local DHT put doesn't reject bad keys #5113

Stebalien opened this issue Jun 14, 2018 · 0 comments · Fixed by #5158
Assignees
@Stebalien
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

Fix: libp2p/go-libp2p-kad-dht#165

(tracking issue for etest_expect_failure sharness test)
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jun 14, 2018
@Stebalien Stebalien self-assigned this Jun 14, 2018
Stebalien added a commit that referenced this issue Jun 14, 2018
@Stebalien
add a failing test case for calling dht put with a bad key
aea0034 
see #5113

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jun 20, 2018
@Stebalien
add a failing test case for calling dht put with a bad key
4bd18d0 
see #5113

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jun 26, 2018
@Stebalien
add a failing test case for calling dht put with a bad key
384e2c4 
see #5113

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien added a commit that referenced this issue Jun 26, 2018
@Stebalien
gx update
8f11aa8 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes #5113
unblocks #4895

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien mentioned this issue Jun 27, 2018
Merged
2 tasks
@ghost ghost added the status/in-progress In progress label Jun 27, 2018
Stebalien added a commit that referenced this issue Jun 27, 2018
@Stebalien
gx update
3eba14a 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes #5113
unblocks #4895

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost removed the status/in-progress In progress label Jun 27, 2018
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
gx update
806561f 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes ipfs#5113
unblocks ipfs#4895

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
go-ipfs-config: gx update
f9dd701 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes ipfs#5113
unblocks ipfs#4895

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
@Stebalien
go-ipfs-config: gx update
7fded30 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes ipfs#5113
unblocks ipfs#4895

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Apr 7, 2022
@Stebalien
gx update
0821b4d 
Updates:

* go-kad-dht: Query performance improvements, DHT client fixes, validates
  records on *local* put.
* go-libp2p-swarm/go-libp2p-transport: Timeout improvements.
* go-multiaddr-net: Exposes useful Conn methods (CloseWrite, CloseRead, etc.)
* go-log: fixes possible panic when enabling/disabling events.
* go-multiaddr: fixes possible panic when stringifying malformed multiaddrs,
  adds support for consuming /p2p/ multiaddrs.

fixes ipfs#5113
unblocks ipfs#4895

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gx update ipfs/kubo
1 participant
@Stebalien