-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "Addresses.Gateway" / "Addresses.API" to be array (Allow gateway/api to listen on multiple addresses) #5401
Comments
hey @Stebalien,if anyone work for this issue?if not,can i do for this? |
@kjzz sorry, I'm fixing it. |
@Stebalien this feature refers to go-ipfs-config, should modify it first? |
Yes, and there's an fs-repo migration required, to do the string-to-array conversion in existing config files: https://github.com/ipfs/fs-repo-migrations -- best to coordinate with @kevina here |
To repeat my comment from ipfs/go-ipfs-config#11 (comment), if we're not careful, we'll break Instead of migrating, I'd prefer to support both through something like ipfs/go-ipfs-config#11. However, supporting two JSON config formats is a bit hacky. |
Version information:
Type: feature
Description: Allow "Addresses.Gateway" / "Addresses.API" properties to be arrays (Allow gateway/api to listen on multiple addresses)
Currently it's only possible to make the gateway/API listen on one address only.
Instead both of these parameters should accept arrays to make it possible to for ex listen on
/ip6/::1/tcp/8080
as well.The text was updated successfully, but these errors were encountered: