Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "Addresses.Gateway" / "Addresses.API" to be array (Allow gateway/api to listen on multiple addresses) #5401

Closed
mkg20001 opened this issue Aug 27, 2018 · 6 comments
Labels
kind/feature A new feature

Comments

@mkg20001
Copy link

Version information:

go-ipfs version: 0.4.17-
Repo version: 7
System version: amd64/linux
Golang version: go1.10.3

Type: feature

Description: Allow "Addresses.Gateway" / "Addresses.API" properties to be arrays (Allow gateway/api to listen on multiple addresses)

Currently it's only possible to make the gateway/API listen on one address only.

Instead both of these parameters should accept arrays to make it possible to for ex listen on /ip6/::1/tcp/8080 as well.

@Stebalien Stebalien added the kind/feature A new feature label Aug 28, 2018
@kjzz
Copy link
Contributor

kjzz commented Sep 5, 2018

hey @Stebalien,if anyone work for this issue?if not,can i do for this?

@overbool
Copy link
Contributor

overbool commented Sep 6, 2018

@kjzz sorry, I'm fixing it.

@overbool
Copy link
Contributor

overbool commented Sep 6, 2018

@Stebalien this feature refers to go-ipfs-config, should modify it first?

@ghost
Copy link

ghost commented Sep 15, 2018

this feature refers to go-ipfs-config, should modify it first?

Yes, and there's an fs-repo migration required, to do the string-to-array conversion in existing config files: https://github.com/ipfs/fs-repo-migrations -- best to coordinate with @kevina here

@Stebalien
Copy link
Member

To repeat my comment from ipfs/go-ipfs-config#11 (comment), if we're not careful, we'll break ipfs config "Addresses.API" "/ip4/127.0.0.1/tcp/1234". Unfortunately, this will break a ton of automation.

Instead of migrating, I'd prefer to support both through something like ipfs/go-ipfs-config#11. However, supporting two JSON config formats is a bit hacky.

@ghost
Copy link

ghost commented Oct 5, 2018

Taken care of in #5532 and #5553

@ghost ghost closed this as completed Oct 5, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A new feature
Projects
None yet
Development

No branches or pull requests

4 participants