allow multiple API/Gateway addresses #11
Conversation
ghost
assigned 
|
I have a hunch we should really make fs-repo-migrations easier to write, with generators or templates, or something like that. Given that one of the most prominent devs is trying to avoid migrations :) |
|
My primary issue with migrations is having to download them. That adds an extra update step that can easily fail. Also, this change will probably break a ton of our test tooling (as it will break |
Stebalien
force-pushed
the
feat/multi-addr
branch
from
8b4cdc9 to
8f3f64a
Compare
Alternative to #6 that doesn't require a migration.
Stebalien
force-pushed
the
feat/multi-addr
branch
from
8f3f64a to
0386478
Compare
|
So, @whyrusleeping at least doesn't think this is that bad and, unlike #6, this doesn't break any existing tooling (i.e., anything that runs |
| func (o Strings) MarshalJSON() ([]byte, error) { | ||
| switch len(o) { | ||
| case 0: | ||
| return json.Marshal(nil) |
There was a problem hiding this comment.
Shouldn't this be returning an empty array? Or will the marshaller just omit the entry if it's nil?
There was a problem hiding this comment.
json.Marshal(nil) will get the value []byte("null"), so i think it makes sense.
There was a problem hiding this comment.
Exactly. Basically, I'd like to use null for the case where no API addresses are specified.
There was a problem hiding this comment.
@overbool want to file a PR against go-ipfs that uses this?
There was a problem hiding this comment.
@Stebalien Did you mean this ipfs/kubo#5401?
ghost
deleted the
Alternative to #6 that doesn't require a migration. This is probably a terrible idea.