-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CIDv1 from Base58 to Base32 (go-ipfs) #6220
Labels
status/in-progress
In progress
Comments
lidel
changed the title
Switch CIDv1 from Base58 to Base32
Switch CIDv1 from Base58 to Base32 (go-ipfs)
Apr 15, 2019
You can currently pass the |
Correct. The change suggested here is that user should not need to pass anything to get Base32 if they already opted-in to CIDv1 via |
Stebalien
added a commit
that referenced
this issue
May 6, 2019
fixes #6220 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
3 tasks
ghost
assigned Stebalien
May 6, 2019
Stebalien
added a commit
that referenced
this issue
May 7, 2019
fixes #6220 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added a commit
that referenced
this issue
May 7, 2019
fixes #6220 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added a commit
that referenced
this issue
May 7, 2019
fixes #6220 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added a commit
that referenced
this issue
May 7, 2019
fixes #6220 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added a commit
that referenced
this issue
May 13, 2019
fixes #6220 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
gfanton
added a commit
to berty/go-ipfs-log
that referenced
this issue
Jun 12, 2019
go-cid@0.0.2 use base32 by default (ipfs/kubo#6220)
gfanton
added a commit
to berty/go-ipfs-log
that referenced
this issue
Jun 12, 2019
go-cid@0.0.2 use base32 by default (ipfs/kubo#6220)
gfanton
added a commit
to berty/go-ipfs-log
that referenced
this issue
Jun 12, 2019
go-cid@0.0.2 use base32 by default (ipfs/kubo#6220)
gfanton
added a commit
to gfanton/go-ipfs-log
that referenced
this issue
Jun 12, 2019
go-cid@0.0.2 use base32 by default (ipfs/kubo#6220)
gfanton
added a commit
to gfanton/go-ipfs-log
that referenced
this issue
Jun 12, 2019
go-cid@0.0.2 use base32 by default (ipfs/kubo#6220)
gfanton
added a commit
to gfanton/go-ipfs-log
that referenced
this issue
Jun 12, 2019
go-cid@0.0.2 use base32 by default (ipfs/kubo#6220)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Right now if someone wants to use CIDv1 they can opt-in via
--cid-version 1
, but by default they get CIDv1 in Base58:To get the representation we aim for, they need to convert Base58 CIDv1 to Base32 in additional step:
The need for the conversion step is not only unnecessary, but harmful to our migration efforts. Users report confusion why CIDv1 produced by go-ipfs can't be used in
<cid>.ipfs.dweb.link
and why Web UI swaps out the CID.It is really embarrassing when we need to ask people to use
ipfs cid base32
during demos and workshops ("why do i need to convert? isn't base32 the future default for CIDv1?")Solution
We should switch default representation of CIDv1 from Base58 to Base32 (without making CIDv1 the default itself).
This will ensure that:
ipfs add --cid-version 1
and use the output immediately(small change, huge UX improvement)
bafy..
CIDsReferences
bafy
CID but in the breadcrumb & the CID info it's displayed aszdj
CID" CID formatting changes ipfs-webui#999The text was updated successfully, but these errors were encountered: