Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Datastore thread-safety issues #87

Closed
btc opened this issue Sep 17, 2014 · 2 comments
Closed

Address Datastore thread-safety issues #87

btc opened this issue Sep 17, 2014 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@btc
Copy link
Contributor

btc commented Sep 17, 2014

Some datastores are not thread-safe. Eg. Datastore implementations backed by the Go map.

Proposal: Introduce datastore.go's new ThreadsafeDatastore interface.

Original: #85 (comment)
@btc btc added the kind/bug A bug in existing code (including security flaws) label Sep 17, 2014
@btc btc self-assigned this Sep 17, 2014
@btc btc changed the title Make datastores thread-safe Address Datastore thread-safety issues Sep 17, 2014
@btc btc mentioned this issue Sep 17, 2014
Merged
@whyrusleeping
Copy link
Member

I beleive that the mutex wrapped datastore solves this issue. @jbenet agree?

@jbenet
Copy link
Member

jbenet commented Oct 6, 2014

Yep it should. Cause I think levigo/leveldb is re entrant.—
Sent from Mailbox

On Sun, Oct 5, 2014 at 8:04 PM, Jeromy Johnson notifications@github.com
wrote:

I beleive that the mutex wrapped datastore solves this issue. @jbenet agree?

Reply to this email directly or view it on GitHub:
#87 (comment)

@btc btc removed their assignment Mar 30, 2015
@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
Closed
72 tasks
ribasushi pushed a commit that referenced this issue Jul 4, 2021
@Stebalien
Merge pull request #87 from iand/iand/pipes
8c45666 
Support in-memory pipes to read from log
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@Stebalien
Merge pull request ipfs#87 from libp2p/gx/update-37wfbd
b2b714d 
gx: update go-ws-transport
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
Closed
80 tasks
hacdias pushed a commit that referenced this issue Nov 29, 2023
@web3-bot
sync: update CI config files (#87)
c8467a6 
This commit was moved from ipfs/interface-go-ipfs-core@de3410b

This commit was moved from ipfs/boxo@ea6ac8c
hacdias pushed a commit that referenced this issue Nov 29, 2023
@web3-bot
sync: update CI config files (#87)
f2614d9 
This commit was moved from ipfs/interface-go-ipfs-core@de3410b

This commit was moved from ipfs/boxo@ea6ac8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbenet @btc @whyrusleeping