Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkreleaselog not working #9012

Closed
3 tasks done
guseggert opened this issue Jun 6, 2022 · 1 comment · Fixed by #9054
Closed
3 tasks done

mkreleaselog not working #9012

guseggert opened this issue Jun 6, 2022 · 1 comment · Fixed by #9054
Assignees
@Jorropo
Labels
kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now topic/release Topic release
Milestone
Best Effort Track

Comments

@guseggert
Copy link
Contributor

Checklist

Installation method

built from source

Version

No response

Config

No response

Description

This seems to be related to the script assuming that the module source is in $GOPATH/src.

$ ./bin/mkreleaselog 
Computing old deps...
Computing new deps...
Generating Changelog for github.com/ipfs/go-ipfs v0.12.2..dc1c67a98a6ce15af5f0fd0aea42409bf2980e56
- github.com/ipfs/go-ipfs:
fatal: cannot change to '/home/gus/.asdf/installs/golang/1.18.1/packages/src/github.com/ipfs/go-ipfs': No such file or directory
@guseggert guseggert added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jun 6, 2022
@guseggert
Copy link
Contributor Author

Workaround:

cd <go-ipfs repo>
gopath="$(go env GOPATH)"
mkdir -p "$gopath/src/github.com/ipfs"
ln -s "$PWD" "$gopath/src/github.com/ipfs/go-ipfs"
./bin/mkreleaselog
rm -rf "$gopath/src/"*

Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 7, 2022
@Jorropo
fix: mkreleaselog
de38be4 
Fixes ipfs#9012
@Jorropo Jorropo mentioned this issue Jun 7, 2022
Closed
@Jorropo Jorropo added P0 Critical: Tackled by core team ASAP topic/release Topic release and removed need/triage Needs initial labeling and prioritization labels Jun 7, 2022
@BigLep BigLep moved this to 🔎 In Review in IPFS Shipyard Team Jun 7, 2022
Stebalien added a commit that referenced this issue Jun 23, 2022
@Stebalien
fix: pass the repo directory into the ignored_commit function
862de81 
fixes #9012
@Stebalien Stebalien mentioned this issue Jun 23, 2022
Merged
@BigLep BigLep added P3 Low: Not priority right now and removed P0 Critical: Tackled by core team ASAP labels Sep 1, 2022
@BigLep BigLep added this to the Best Effort Track milestone Sep 1, 2022
Jorropo pushed a commit that referenced this issue Sep 1, 2022
@Stebalien @Jorropo
fix: pass the repo directory into the ignored_commit function
d2c4927 
fixes #9012
Repository owner moved this from 🔎 In Review to 🎉 Done in IPFS Shipyard Team Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jorropo Jorropo

Labels
kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now topic/release Topic release
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
Best Effort Track
3 participants
@BigLep @guseggert @Jorropo