Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AcceleratedDHTClient from being experimental #9703

Closed
BigLep opened this issue Mar 8, 2023 · 1 comment · Fixed by #9886
Closed

Move AcceleratedDHTClient from being experimental #9703

BigLep opened this issue Mar 8, 2023 · 1 comment · Fixed by #9886
Assignees

Comments

@BigLep
Copy link
Contributor

BigLep commented Mar 8, 2023

Done Criteria

The AcceleratedDHTClient is no longer communicated as an experimental feature.

Why Important

At least as of 2023-03-07 we have had the config Experimental.AcceleratedDHTClient even though it has been used in production by larger operators for a year plus. Whether we're happy with everything about the feature and implementation or not, we treat it like a production feature. We have seen large operators who would have benefitted from it, but weren't even aware. We're going to drive more awareness about the functionality, but before doing so, should be making its status clear that it's functionality we support and recommend.

Notes

This issue shouldn't be a license to go do a bunch of code cleanup, but if there is some small improvements to make to improve the maintenance burden we certainly can.

#9419 should get completed as part of this.

@BigLep
Copy link
Contributor Author

BigLep commented May 16, 2023

2023-05-16 maintainer conversation:

  • Need to add an error message in some case
  • Need a PR to config.md (this is coming in the PR for this issue)

Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 1, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 2, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 2, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 2, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 2, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 2, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 2, 2023
@BigLep BigLep mentioned this issue Jun 2, 2023
5 tasks
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 7, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 7, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 7, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 7, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 8, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 8, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 8, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 8, 2023
Jorropo added a commit to Jorropo/go-ipfs that referenced this issue Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants