Plugin loading doesn't respect the expected order

[MichaelMure]

Checklist

• This is a bug report, not a question. Ask questions on discuss.ipfs.io.
• I have searched on the issue tracker for my bug.
• I am running the latest kubo version or have an issue updating.

Installation method

built from source

Version

master branch

Config

No response

Description

I'm not entirely sure if it's a bug or a massive foot-gun, but it goes like this:

• kubo use the preload_list file that list which plugin to load, and generate the corresponding loading code at compile time (ALL GOOD)
• this code take each plugin package, and for those, each actual plugin from the declared slice (ALL GOOD)
• kubo pass each of those to PluginLoader.Load() which collect them into a map (HUUU)
• kubo call PluginLoader.Inject() to trigger the actual injection by iterating on that map (PROBLEM)

Golang's map iteration is famously non-deterministic ... which means kubo load those plugins in random order, and doesn't respect an eventual ordering constraint.