Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: path consolidation #10063

Merged
merged 5 commits into from
Oct 6, 2023
Merged

feat: path consolidation #10063

merged 5 commits into from
Oct 6, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Aug 11, 2023

@hacdias hacdias added the skip/changelog This change does NOT require a changelog entry label Aug 11, 2023
@hacdias hacdias force-pushed the path-consolidation branch 4 times, most recently from 5b19227 to 1542d6e Compare August 21, 2023 14:27
@hacdias hacdias force-pushed the path-consolidation branch 2 times, most recently from 9e7a70e to edbed55 Compare August 22, 2023 13:16
@hacdias hacdias changed the base branch from master to remove-mplex August 22, 2023 13:16
@hacdias hacdias force-pushed the path-consolidation branch 2 times, most recently from 1b12387 to ae2eb7e Compare August 22, 2023 13:58
@hacdias hacdias self-assigned this Aug 22, 2023
@hacdias hacdias marked this pull request as ready for review August 22, 2023 14:08
@hacdias hacdias requested review from lidel and a team as code owners August 22, 2023 14:08
@hacdias hacdias changed the base branch from remove-mplex to internalize-mplex August 23, 2023 08:46
Base automatically changed from internalize-mplex to master August 24, 2023 06:11
@hacdias hacdias force-pushed the path-consolidation branch 2 times, most recently from 3ce9189 to bf9a3a1 Compare August 28, 2023 08:22
@hacdias hacdias force-pushed the path-consolidation branch 5 times, most recently from d9bca2c to 8eb565d Compare September 5, 2023 13:27
@hacdias hacdias force-pushed the path-consolidation branch 4 times, most recently from 6338df4 to f5b4175 Compare September 7, 2023 09:22
@hacdias hacdias force-pushed the path-consolidation branch 2 times, most recently from 77ea675 to 4b18d58 Compare September 18, 2023 08:35
@hacdias hacdias force-pushed the path-consolidation branch 3 times, most recently from f78a7ee to 21d1144 Compare September 27, 2023 11:12
@hacdias hacdias force-pushed the path-consolidation branch 3 times, most recently from ae8c8a1 to b9ce207 Compare October 5, 2023 10:52
@hacdias hacdias merged commit a7c6518 into master Oct 6, 2023
19 checks passed
@hacdias hacdias deleted the path-consolidation branch October 6, 2023 14:14
@hacdias hacdias mentioned this pull request Oct 18, 2023
11 tasks
@@ -62,13 +62,19 @@ func (s *Root) Lookup(ctx context.Context, name string) (fs.Node, error) {
return nil, syscall.Errno(syscall.ENOENT)
}

p, err := path.ParsePath(name)
p, err := path.NewPath(name)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hacdias I think this change might've broken fuse ipfs mount (ipns still works, I think):

2023-11-28T14:01:52.654+0100    DEBUG   fuse/ipfs       readonly/readonly_unix.go:67    fuse failed
 to parse path: "QmREP1hYvkmdfHN3ybouWFaB7BenoinYRhWgcMwVWdutw4": invalid path "QmREP1hYvkmdfHN3ybo
uWFaB7BenoinYRhWgcMwVWdutw4": path does not have enough components

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is broken beyond that though, adding /ipfs/ prefix results in:

2023-11-28T14:14:19.976+0100    DEBUG   fuse/ipfs       readonly/readonly_unix.go:58    Root Lookup: 'Qmde3RkqLihpS2ehi8VqUm6gZ9dCVGg4AvqGRcK5uvt78z'
2023-11-28T14:14:19.977+0100    ERROR   fuse/ipfs       readonly/readonly_unix.go:113   could not convert protobuf or raw node: expected protobuf dag node

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crackcomm thanks for pinging. We are trying to take a look at it in #10243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants