Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip changelog] improve error in fuse node failures #10102

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[skip changelog] improve error in fuse node failures #10102

merged 1 commit into from
Aug 25, 2023

Conversation

willscott
Copy link
Contributor

the underlying error when a protobuf is not able to be converted as expected during a fuse read is not being lost but silently dropped

@willscott willscott requested a review from a team as a code owner August 25, 2023 12:52
@willscott willscott mentioned this pull request Aug 25, 2023
Open
3 tasks
aschmahmann
aschmahmann approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I'll add a "skip changelog" for this one unless you wanted to add a changelog entry.

@aschmahmann aschmahmann changed the title improve error in fuse node failures [skip changelog] improve error in fuse node failures Aug 25, 2023
@aschmahmann aschmahmann merged commit 86bde28 into master Aug 25, 2023
@aschmahmann aschmahmann deleted the fix/fuse-error-verbosity branch August 25, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willscott @aschmahmann