Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to build with Go 1.21 #10123

Merged
merged 1 commit into from
Sep 18, 2023
Merged

chore: update to build with Go 1.21 #10123

merged 1 commit into from
Sep 18, 2023

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Sep 18, 2023

resolves (and testing) #10064

@aschmahmann aschmahmann requested a review from a team as a code owner September 18, 2023 13:41
@lidel
Copy link
Member

lidel commented Sep 18, 2023

cc @laurentsenta @hacdias i think we need to fix ipfs/gateway-conformance/.github/actions/test before release, so it works with go1.21 🙏

@laurentsenta
Copy link
Contributor

laurentsenta commented Sep 18, 2023

@lidel @hacdias issue fixed itself, tests are dockerized so go version bumps should never be a problem.

That PR caught the 8-minutes window during which the gateway conformance workflow file was v0.3.1 (we just released) but the docker image was v0.3.0 (it takes some time to publish the image). 🤯 timing.

Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests pass, I think we're good to go.

@hacdias hacdias merged commit a9737e4 into master Sep 18, 2023
15 checks passed
@hacdias hacdias deleted the chore/update-go-1.21 branch September 18, 2023 15:05
@hacdias hacdias mentioned this pull request Sep 18, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants