feat: enables searching pins by name #10412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
approved these changes
May 6, 2024
There was a problem hiding this comment.
Thanks for submitting this! I think it's a good idea to search for the exact name matches as a first iteration. In the future, I think it could be nice to have something with regular expressions too. The code looks fine to me and thanks for adding a test.
However, it does not match exactly the idea from #10281. Below you can find some comments of suggestions of what could be changed to make it slightly more generic (using contains instead of equal).
@lidel what do you think? I'm fine either way, but I think searching for something that contains the given name could be more valuable than for exact matches only.
hacdias
reviewed
May 6, 2024
hacdias
reviewed
May 6, 2024
Co-authored-by: Henrique Dias <mail@hacdias.com>
Co-authored-by: Henrique Dias <mail@hacdias.com>
lidel
added a commit
to lidel/ipfs-banana
that referenced
this pull request
May 14, 2024
ipfs#10412 changed this to partial match, but we forgot to update --help before merge
lidel
added a commit
that referenced
this pull request
May 14, 2024
#10412 changed to be partial match but we forgot to update --help text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10281.
This PR introduces the possibility to perform a search on pin names (case-sensitive, exact search). The command
ipfs pin ls --name "pinName"will return all the pins labeled aspinName.Notes:
displayNames || name != ""is implemented to prevent redundancy in specifying the--nameoption. This ensures that users can simply useipfs ls --name Ainstead ofipfs ls --names --name A.