Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-ipfs-cmds and boxo #10485

Merged
merged 2 commits into from
Aug 21, 2024
Merged

chore: update go-ipfs-cmds and boxo #10485

merged 2 commits into from
Aug 21, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 20, 2024

@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Aug 20, 2024
@lidel lidel force-pushed the chore/update-go-ipfs-cmds branch 3 times, most recently from 211d472 to 683a10b Compare August 20, 2024 19:04
@lidel lidel changed the title chore: update go-ipfs-cmds chore: update go-ipfs-cmds and boxo Aug 21, 2024
@lidel
Copy link
Member Author

lidel commented Aug 21, 2024

I've confirmed CI failed not because of new version, we have a flaky test, filled #10487 to investigate, but it has been flaky since at least v0.22.0 so not blocking updates here.

@lidel lidel marked this pull request as ready for review August 21, 2024 13:49
@lidel lidel requested a review from a team as a code owner August 21, 2024 13:49
@lidel lidel changed the title chore: update go-ipfs-cmds and boxo chore: udpate go-ipfs-cmds, go-libp2p-kad-dht, boxo Aug 21, 2024
@lidel lidel changed the title chore: udpate go-ipfs-cmds, go-libp2p-kad-dht, boxo chore: update go-ipfs-cmds, go-libp2p-kad-dht, boxo Aug 21, 2024
@lidel
Copy link
Member Author

lidel commented Aug 21, 2024

So.. cmds and boxo are ok, but go-libp2p-kad-dht causes trouble.
I'm going to move go-libp2p-kad-dht update to separate PR.

@lidel lidel changed the title chore: update go-ipfs-cmds, go-libp2p-kad-dht, boxo chore: update go-ipfs-cmds and boxo Aug 21, 2024
@lidel lidel merged commit 3308185 into master Aug 21, 2024
30 checks passed
@lidel lidel deleted the chore/update-go-ipfs-cmds branch August 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant