Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify logic for MFS remote pinning #10506

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Sep 5, 2024

  1. Simplify logic for MFS pinning

    MFS pinning logis was returning errors on a channel, only to be logged by a separate goroutine. The errors were not used for any other purpose, so the logic could be significantly simplified by logging the error where it happened instead of returning it on a channel to be logged. This PR removes the unnecessary channel and logging goroutine.
    
    Some other minor simplifications and consistency changes were also made, such as passing a context as the first argument.
    gammazero committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e5fd8df View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    4e4e3aa View commit details
    Browse the repository at this point in the history