-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically acquire WSS certificates from libp2p.direct #10521
Draft
aschmahmann
wants to merge
7
commits into
master
Choose a base branch
from
feat/libp2p-direct
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+271
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-forge and libp2p.direct
aschmahmann
force-pushed
the
feat/libp2p-direct
branch
from
September 18, 2024 21:45
3d6cb4d
to
ecfc8d9
Compare
lidel
reviewed
Sep 18, 2024
@@ -252,3 +258,5 @@ require ( | |||
) | |||
|
|||
go 1.22 | |||
|
|||
replace github.com/libp2p/go-libp2p => github.com/libp2p/go-libp2p v0.36.3-0.20240909195832-fbc0ac8f743c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remove once libp2p/go-libp2p#2854 lands
core/node/libp2p/addrs.go
Outdated
Comment on lines
145
to
150
p2pforge.WithModifiedForgeRequest(func(req *http.Request) error { | ||
if foundAuthKey { | ||
req.Header.Set(authForgeHeader, authKey) | ||
} | ||
return nil | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: too low level, we need to move this to p2p-forge/client
library, and call specific funcs here:
WithForgeAuth(authKey)
WithUserAgent(GetUserAgentVersion())
lidel
reviewed
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is WIP but the intention is to allow any publicly reachable node on the network to be reachable via Secure WebSockets and thereby improve reachability from browsers. For anyone who reads this and is unfamiliar with this work, don't worry plenty of documentation to come before we're ready to merge.
TLDR
TODO
Some outstanding items here are: