remove msgio double wrap #1065
Closed
remove msgio double wrap #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was doublewrapping with an unneeded msgio. given that we use a stream muxer now, msgio is only needed by secureConn -- to signal the boundaries of an encrypted / mac-ed ciphertext. Side note: i think including the varint length in the clear is actually a bad idea that can be exploited by an attacker. it should be encrypted, too. (TODO)
|
@whyrusleeping CR pls |
|
LGTM, did you run all the tests? |
|
@whyrusleeping good point. running on jupiter now |
|
3nodetest passed on cassi |
|
yep, passed on jupiter too. |
|
should we start a |
|
When do we want this to land? |
|
with the wire fmt / stream muxer changes. i'll have the spec of what we want done this week, so maybe we could impl next week |
|
i'd like to work on merging this soon. it fixes #1304 |
|
@whyrusleeping yeah we'll merge it as we move to interop with ipfs/js-ipfs#13 (comment) -- making the multistream + spdy stuff work will help here. |
|
being merged in dev0.4.0 |
|
closing, old pr cleanup time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was doublewrapping with an unneeded msgio. given that we
use a stream muxer now, msgio is only needed by secureConn -- to
signal the boundaries of an encrypted / mac-ed ciphertext.
Side note: i think including the varint length in the clear is
actually a bad idea that can be exploited by an attacker. it should
be encrypted, too. (TODO)
WARNING: THIS PR BREAKS THE PROTOCOL. DO NOT MERGE UNTIL NEXT
PROTOCOL VERSION BUMP.