core/commands/ls: Remove trailing tabs #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
Guidelines are available at: https://github.com/ipfs/community/blob/master/docs/commit-message.md Your feedback on GitCop is welcome on the following issue: ipfs/infra#23 This message was auto-generated by https://gitcop.com |
wking
force-pushed
the
tk/ls-trailing-tabs
branch
from
3b244d2
to
97119da
Compare
|
There were the following issues with your Pull Request
Guidelines are available at: https://github.com/ipfs/community/blob/master/docs/commit-message.md Your feedback on GitCop is welcome on the following issue: ipfs/infra#23 This message was auto-generated by https://gitcop.com |
wking
force-pushed
the
tk/ls-trailing-tabs
branch
2 times, most recently
from
2ec0ba4
to
15135e1
Compare
Since 607468a (beautify 'ipfs ls' and 'ipfs object links', #833) we've had these. That pull request was about text/tabwriter [1] and elastic tabstops [2], but we don't need a column separator at the end of each line. [1]: https://golang.org/pkg/text/tabwriter/ [2]: http://nickgravgaard.com/elastic-tabstops/index.html Licence: MIT Signed-off-by: W. Trevor King <wking@tremily.us>
|
GitCop, you need to chill out bro. |
|
this LGTM, lets get it rebased and merged so i can have fewer than 30 open PRs |
|
LGTM |
jbenet
added a commit
that referenced
this pull request
Jun 16, 2015
core/commands/ls: Remove trailing tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 607468a (beautify 'ipfs ls' and 'ipfs object links', #833)
we've had these. That pull request was about text/tabwriter and
elastic tabstops, but we don't need a column separator at the end
of each line.