Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proto fix #1439

Merged
merged 2 commits into from
Jul 2, 2015
Merged

Proto fix #1439

merged 2 commits into from
Jul 2, 2015

Conversation

whyrusleeping
Copy link
Member

The msgio fixes from #1380 since the spdystream changes were redone in #1438

@GitCop
Copy link

GitCop commented Jul 1, 2015

There were the following issues with your Pull Request

  • Commit: 0c9d90f
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>
  • Commit: 018db49
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue

This message was auto-generated by https://gitcop.com

@whyrusleeping whyrusleeping added the status/in-progress In progress label Jul 1, 2015
@whyrusleeping whyrusleeping mentioned this pull request Jul 1, 2015
Closed
@whyrusleeping
Copy link
Member Author

prefer to merge this before #1438

jbenet and others added 2 commits July 1, 2015 15:46
@jbenet @whyrusleeping
remove msgio double wrap
c42b501 
There was doublewrapping with an unneeded msgio. given that we
use a stream muxer now, msgio is only needed by secureConn -- to
signal the boundaries of an encrypted / mac-ed ciphertext.

Side note: i think including the varint length in the clear is
actually a bad idea that can be exploited by an attacker. it should
be encrypted, too. (TODO)
@whyrusleeping
buffer msgio
956e398
@GitCop
Copy link

GitCop commented Jul 1, 2015

There were the following issues with your Pull Request

  • Commit: c42b501
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>
  • Commit: 956e398
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue

This message was auto-generated by https://gitcop.com

@whyrusleeping whyrusleeping added codereview and removed status/in-progress In progress labels Jul 2, 2015
jbenet added a commit that referenced this pull request Jul 2, 2015
@jbenet
Merge pull request #1439 from ipfs/proto-fix
db6e00f 
Proto fix
@jbenet jbenet merged commit db6e00f into dev0.4.0 Jul 2, 2015
@jbenet jbenet removed the codereview label Jul 2, 2015
@jbenet jbenet deleted the proto-fix branch July 2, 2015 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whyrusleeping @GitCop @jbenet