Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix races in HTTP CORS #1833

Closed
wants to merge 16 commits into from
Closed

Fix races in HTTP CORS #1833

wants to merge 16 commits into from

Conversation

miolini
Copy link
Contributor

@miolini miolini commented Oct 12, 2015

No description provided.

@miolini
fix races in http cors
90f867e 
License: MIT
Signed-off-by: Artem Andreenko <mio@volmy.com>
@miolini
Merge branch 'master' of https://github.com/ipfs/go-ipfs
70ea620 
# By Jeromy
# Via Juan Benet (2) and Jeromy (1)
* 'master' of https://github.com/ipfs/go-ipfs:
  fix random bitswap hangs
  vendor in new iptb code (and as a result, go-multiaddr-net and friends
  update go-peerstream dependency
  update go-multiaddr-net dependency

License: MIT
Signed-off-by: Artem Andreenko <miolini@gmail.com>
@jbenet jbenet added the backlog label Oct 12, 2015
@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 1b91843
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@miolini
fix test in commands/http/handler_test.go
fea31d6 
License: MIT
Signed-off-by: Artem Andreenko <miolini@gmail.com>
@miolini
Merge branch 'master' of github.com:miolini/go-ipfs
a7f9ded 
* 'master' of github.com:miolini/go-ipfs:
  fix test in commands/http/handler_test.go
@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 1b91843
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: a7f9ded
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@miolini
Merge branch 'master' of github.com:miolini/go-ipfs
e8c1fbd 
* 'master' of github.com:miolini/go-ipfs:
  fix test in commands/http/handler_test.go

License: MIT
Signed-off-by: Artem Andreenk <mio@volmy.com>
@miolini
Merge branch 'master' of github.com:miolini/go-ipfs
65791ad 
* 'master' of github.com:miolini/go-ipfs:
@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 1b91843
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: a7f9ded
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: 65791ad
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@miolini
Merge branch 'master' of github.com:miolini/go-ipfs
b59cc35 
* 'master' of github.com:miolini/go-ipfs:

License: MIT
Signed-off-by: Artem Andreenk <mio@volmy.com>
@miolini
fix return in http test
6c17d00 
License: MIT
Signed-off-by: Artem Andreenk <mio@volmy.com>
@miolini
Merge branch 'master' of github.com:miolini/go-ipfs
2837e7b 
License: MIT
Signed-off-by: Artem Andreenk <mio@volmy.com>
@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 1b91843
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: a7f9ded
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: 65791ad
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@miolini
fix http tests
05f04c3 
License: MIT
Signed-off-by: Artem Andreenk <mio@volmy.com>
@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 1b91843
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: a7f9ded
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: 65791ad
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@chriscool
Copy link
Contributor

@miolini you should probably squash some of your commits together and then force push in the same branch to replace all the existing commits in this PR.

Thanks!

@miolini
fix races in http cors
25bbb10 
License: MIT
Signed-off-by: Artem Andreenko <mio@volmy.com>
@miolini
fix test in commands/http/handler_test.go
c11da71 
License: MIT
Signed-off-by: Artem Andreenko <mio@volmy.com>
@miolini
fix return in http test
8b8cd1a 
License: MIT
Signed-off-by: Artem Andreenko <mio@volmy.com>
@miolini
fix http tests
d6c618b 
License: MIT
Signed-off-by: Artem Andreenko <mio@volmy.com>
@miolini
Merge branch 'master' of github.com:miolini/go-ipfs
b871a9c 
License: MIT
Signed-off-by: Artem Andreenko <mio@volmy.com>
@GitCop
Copy link

GitCop commented Oct 12, 2015

There were the following issues with your Pull Request

  • Commit: 1b91843
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: a7f9ded
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>
  • Commit: 65791ad
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@miolini miolini closed this Oct 12, 2015
@jbenet jbenet removed the backlog label Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miolini @GitCop @chriscool @jbenet