purposely fail builds pre1.5 #1881
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
| @@ -0,0 +1,3 @@ | |||
| // +build !go1.5 | |||
|
|
|||
| `IPFS needs to be built with go version 1.5 or greater` | |||
There was a problem hiding this comment.
func init() {panic("IPFS needs to be built with go version 1.5 or greater")}to not have invalid code? LGTM otherwise
There was a problem hiding this comment.
Yeah, i thought about that, but i'd rather have builds fail than have them succeed and then crash.
Letting the build succeed might lead to shipping bad binaries accidentally
There was a problem hiding this comment.
True, I just feared tools like go list stumbling over this. Also: what happens once go1.6 is out?
There was a problem hiding this comment.
the go version based build tags are incremental, so !go1.5 implies 'dont build this for anything 1.5 or greater'
There was a problem hiding this comment.
maybe once go1.5 is more widely adopted we can remove this again? I had thought that we were able to fail the builds by using the for range syntax, but apparently that compiles under 1.4 for some people...
There was a problem hiding this comment.
does gobuilder still choke on this?
There was a problem hiding this comment.
no, it wont. he merged my PR, note the change to the .gobuilder.yml file
|
let's merge this after 0.3.9 with the trailers is shipped. |
|
@jbenet why after? |
|
@jbenet this needs to be merged now, not later. People are having issues now. postponing this only increases that pain. |
ensures we dont accidentaly run into #1880 by building with go1.4
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com