convert DAGService to an interface #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What i (and @jbenet ) was thinking, was to make the blockservice be RPC backed, that way, a DAGService using an rpc backed blockservice would be also RPC enabled. |
|
@whyrusleeping want to CR this, as you know DAGWriter/Reader better than I do? |
| @@ -157,7 +157,7 @@ func NewIpfsNode(cfg *config.Config, online bool) (*IpfsNode, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| dag := &merkledag.DAGService{Blocks: bs} | |||
| dag := merkledag.NewDAGService(bs) | |||
There was a problem hiding this comment.
been wanting to do this forever...
|
made a couple inconsequential comments, but really, LGTM |
|
I think this needs rebasing now (build errored), but ready to merge whenever. |
|
@ehmry I can do the rebasing for you and merge manually, just lmk. |
|
Ok, ready to go. |
jbenet
added a commit
that referenced
this pull request
Oct 26, 2014
convert DAGService to an interface
|
thanks @ehmry ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is DAGService conversion, leaving the spiltter as-is.
Looking at BlockService, it would makes sense to interface that too, but for me at this point I'd rather have a RPC backed DAGService because its a much more naive way to add objects.
I would perhaps like to run multiple BlockExchange nodes on the same datastore, so that I might publish objects to different networks without exposing the relationship between my different addresses.
There is alot more that goes into that, but its something I've been thinking about.