Fix/add mem 4 #1965
Fix/add mem 4 #1965
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
(Only maximum resident size can be retrieved from dev0.4.0, 1KB each fix/add-mem-4, 1KB each |
| if err == dag.ErrNotFound { | ||
| nd, err = root.GetLinkedNode(ctx, e.src, path[0]) | ||
| } | ||
|
|
There was a problem hiding this comment.
rm this space as it separates the err check clause
There was a problem hiding this comment.
i added the space purposely because i felt it made it more readable, do these things and then in either case check the error.
|
@rht the memory leak was really only noticeable when you started adding hundreds of thousands of files. |
|
@whyrusleeping a proof of your statement And here is without intermediate roots If you subtract the 2nd graph from the 1st, you get the memory growth of creating each intermediate roots. Of all the perf PRs, I think the most effective one is no-intermediate-root, but I encountered an issue with a hash in the travis-ci/pr test (possibly related to the final hash created by |
| } else { | ||
| err = nil // no longer an error case | ||
| } else if err == dag.ErrNotFound { | ||
| nd, err = root.GetLinkedNode(ctx, e.src, path[0]) |
There was a problem hiding this comment.
maybe write why there's two checks here. i get it after reading but useful
|
LGTM otherwise. |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
while @rht's PR makes the performance boost from this PR negligible, its still good to have for anything else that may be using the DagEditor in the future. |
|
merging. |
ghost
deleted the
## [4.2.0](ipfs/ipfs-webui@v4.1.1...v4.2.0) (2023-12-02) CID `bafybeidf7cpkwsjkq6xs3r6fbbxghbugilx3jtezbza7gua3k5wjixpmba` --- ### Features * peers table can be filtered ([#2181](ipfs/ipfs-webui#2181)) ([37b5880](ipfs/ipfs-webui@37b5880)) * **pinning:** add Scaleway pinning service ([#2132](ipfs/ipfs-webui#2132)) ([0cc3b04](ipfs/ipfs-webui@0cc3b04)) ### Bug Fixes * error loading scaleway template URL ([7a3388e](ipfs/ipfs-webui@7a3388e)) * replace estuary with web3 for pinning ([#2182](ipfs/ipfs-webui#2182)) ([e2fc7c8](ipfs/ipfs-webui@e2fc7c8)) * status page supports webrtc ([#2180](ipfs/ipfs-webui#2180)) ([ff75d4e](ipfs/ipfs-webui@ff75d4e)), closes [#1965](ipfs/ipfs-webui#1965) * switch to new dnslink updater ([#2175](ipfs/ipfs-webui#2175)) ([a63f48a](ipfs/ipfs-webui@a63f48a)) ### Trivial Changes * Pull transifex translations ([#2162](ipfs/ipfs-webui#2162)) ([c0f8f54](ipfs/ipfs-webui@c0f8f54)) * pull transifex translations ([#2177](ipfs/ipfs-webui#2177)) ([7f377ff](ipfs/ipfs-webui@7f377ff)) * update release transifex links ([74cce69](ipfs/ipfs-webui@74cce69))
putting #1954 on top of 0.4.0