flatten multipart transfers #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
fix/multipart
branch
from
a9e78c2
to
25d5a00
Compare
|
#2039 is merged -- will review this next |
ghost
added
whyrusleeping
force-pushed
the
dev0.4.0
branch
from
5bf3a59
to
68b9745
Compare
whyrusleeping
force-pushed
the
fix/multipart
branch
from
25d5a00
to
8011c37
Compare
5 tasks
whyrusleeping
force-pushed
the
dev0.4.0
branch
from
68b9745
to
b0a8591
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
fix/multipart
branch
from
8e94f08
to
43e0cc7
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
fix/multipart
branch
2 times, most recently
from
63dcd20
to
a9f0c12
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
| @@ -86,23 +88,9 @@ Some-Header: beep | |||
|
|
|||
| beep | |||
| --Boundary! | |||
| Content-Type: multipart/mixed; boundary=OtherBoundary | |||
| Content-Type: application/x-directory | |||
There was a problem hiding this comment.
Should test file inside the directory as well
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
cool, addressed your concerns @dignifiedquire merging. |
whyrusleeping
added a commit
that referenced
this pull request
Dec 28, 2015
flatten multipart transfers
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #2039 so wait until it merges to review this.
But this removes the whole recursive multipart thing.
The multipart 'Next()' bug in #1688 is what i set out to fix, but that was apparently fixed in go version 1.5.2