Prevents 'ipfs name publish' when /ipns is mounted. #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| test_launch_ipfs_daemon | ||
|
|
||
| # wait for peer bootstrapping | ||
| # TODO(noffle): this is very fragile -- how can we wait for this to happen for sure? |
There was a problem hiding this comment.
check the other iptb tests to see how i wait for bootstrapping
There was a problem hiding this comment.
mostly, the functions in test/sharness/lib/iptb-lib.sh
hackergrrl
force-pushed
the
no_publish_while_mounted
branch
from
1a24479
to
76add1f
Compare
|
Nice! |
|
|
||
| # start iptb + wait for peering | ||
| NUM_NODES=3 | ||
| iptb init -n $NUM_NODES -f --bootstrap=none --port=0 |
There was a problem hiding this comment.
throw this in a test_expect_success
|
one small comment and LGTM |
|
Looks like CI likes me. Ready for merge? |
|
LGTM, wanna rebase and i'll merge? |
|
Done. |
hackergrrl
force-pushed
the
no_publish_while_mounted
branch
from
abf5478
to
f4367f6
Compare
License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
whyrusleeping
added a commit
that referenced
this pull request
Mar 1, 2016
Prevents 'ipfs name publish' when /ipns is mounted.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1186.