Commands Refactor Part 2#263

Closed

jbenet wants to merge 384 commits intomasterfrom cmd-ref-part2

+5,045-189

This pull request is big! We're only showing the most recent 250 commits

Commits on Nov 6, 2014

core/commands2: Added 'config' command
mappum
committed
core/commands2: Added 'bootstrap' command
mappum
committed
core/commands2: Added 'mount' command
mappum
committed
core/commands2: Added 'block' command
mappum
committed
fmt
Brian Tiger Chow
committed
refactor(core/commands2/add) split loop
Brian Tiger Chow
committed
add online method to node
Brian Tiger Chow
committed
check mode with use func node.OnlineMode() bool
Brian Tiger Chow
committed
rename -> OnlineMode()
Brian Tiger Chow
committed
refac(commands2/ls) split loop
Brian Tiger Chow
committed
refac(commands2/pin) loop
Brian Tiger Chow
committed
extract toStrings method
Brian Tiger Chow
committed
add slice utils
Brian Tiger Chow
committed
extract unpin
Brian Tiger Chow
committed

Commits on Nov 7, 2014

fix(cli) tear down node
Brian Tiger Chow
committed
fix(add) cast safely
Brian Tiger Chow
committed
feat(commands2/tour) impl
Brian Tiger Chow
committed
cmd/ipfs2: Set all loggers to DEBUG level when running with 'debug' flag
mappum
committed
commands/http: Log incoming requests (with DEBUG log level)
mappum
committed
core/commands2: Added 'update' command
mappum
committed

Commits on Nov 8, 2014

named imports
Brian Tiger Chow
committed
fix(tour) variadic -> false
Brian Tiger Chow
committed
docs(add) help
Brian Tiger Chow
committed
docs(commands) help
Brian Tiger Chow
committed
docs(net-diag) help + name
Brian Tiger Chow
committed
docs(log) help
Brian Tiger Chow
committed
docs(ls) help
Brian Tiger Chow
committed
todo(ls)
Brian Tiger Chow
committed
fix(mount) add argument
Brian Tiger Chow
committed
add fixmes
Brian Tiger Chow
committed
docs(name/publish/resolve) help
Brian Tiger Chow
committed
refactor(name, pub, resolve) separate files
Brian Tiger Chow
committed
chore(pin) rm commented code
Brian Tiger Chow
committed
pin/unpin -> add rm
Brian Tiger Chow
committed
docs(pin) help
Brian Tiger Chow
committed
fix(name:resolve, name:publish) docs
Brian Tiger Chow
committed
net-diag -> diag net
Brian Tiger Chow
committed
diag doc
Brian Tiger Chow
committed
commands: Added 'Description' fields to Command, Argument, Option
mappum
committed
core/commands2: Added descriptions for 'add', 'block'
mappum
committed
core/commands2: Removed test subcommands
mappum
committed
core/commands2: Added descriptions for all the existing commands
mappum
committed
cmd/ipfs2: Added descriptions for 'init', 'tour'
mappum
committed
core/commands2: Better formatted descriptions for 'mount'
mappum
committed
commands/cli: Added a helptext generator
mappum
committed
commands/cli: Helptext spacing fix for root command output
mappum
committed
commands/cli: Output command path in Parse
mappum
committed
cmd/ipfs2: Output generated help text on error or help flag
mappum
committed
core/commands2: Updated root help text
mappum
committed
commands: Fixed tests
mappum
committed

Commits on Nov 9, 2014

Commits on Nov 11, 2014

commands: Made Command run functions return (interface{}, error) instead of setting the values in the response
mappum
committed
core/commands2: Updated commands to new Run function API
mappum
committed
commands: Added Option helper constructors
mappum
committed
core/commands2: Use Option constructors in commands
mappum
committed
commands: Fixed tests
mappum
committed
commands: Added list of option definitions to Request, so Option can lookup values by all aliases
mappum
committed
cmd/ipfs2: Cleaned up main option checking (no longer need temporary Request)
mappum
committed
commands: Updated tests
mappum
committed
commands: Made SetOption override existing values (even if they used a different alias)
mappum
committed
commands: Changed option accessor API (Request#Option now returns an OptionValue)
mappum
committed
core/commands2: Fixed init option definition
mappum
committed
commands: Fixed handling of int/uint option values
mappum
committed
commands: Removed a fmt.Println
mappum
committed
refactor(ipfs2/main) return errors in main
Brian Tiger Chow
committed
refactor(ipfs2/main) split lines
Brian Tiger Chow
committed
refactor(ipfs2/main) check err before
Brian Tiger Chow
committed
refactor(ipfs2/main) same for debug
Brian Tiger Chow
committed
refactor(ipfs2/main)
Brian Tiger Chow
committed
refactor(ipfs2/main) return err
Brian Tiger Chow
committed
refactor(ipfs2/main) output response
Brian Tiger Chow
committed
refactor(ipfs2/main) replace with equivalent action
Brian Tiger Chow
committed
refactor(ipfs2/main) return err
Brian Tiger Chow
committed
refactor(ipfs2/main) change the way we handle profiling
Brian Tiger Chow
committed
refactor(ipfs2/main) use guard
Brian Tiger Chow
committed
refactor(ipfs2/main) rm exit
Brian Tiger Chow
committed
commands: Added Argument helper constructors
mappum
committed
core/commands2: Use Argument constructors in commands
mappum
committed

Commits on Nov 12, 2014

cmd/ipfs2: Updated readme
mappum
committed
cmd/ipfs2: Added explanation comment to ipfsHandler
mappum
committed
cmd/ipfs2: Added comment to explain default encoding logic
mappum
committed
commands/cli: Added comment to explain multiple root support in Parse
mappum
committed
commands/cli: Use better temp variable names in Parse
mappum
committed
commands/cli: Use better variable name for parseArgs value index
mappum
committed
commands: s/lenRequired/numRequired/
mappum
committed
commands: s/j/valueIndex/
mappum
committed
commands/http: s/lenRequired/numRequired/
mappum
committed
core/command2: Fixed indentation
mappum
committed
commands: Allow overriding helptext sections with hand-written strings
mappum
committed
Override root command help text
mappum
committed
change(Makefile) make install -> make install_1, make install_2
Brian Tiger Chow
committed
add urgent todo. fix before merge
Brian Tiger Chow
committed
docs(commands) Type
Brian Tiger Chow
committed
docs(commands) amend
Brian Tiger Chow
committed
commands/cli: Use template for helptext generation
mappum
committed
commands/cli: Added short help text function
mappum
committed
cmd/ipfs2: Show short help text instead for usage errors
mappum
committed
Handle -h and --help differently (short text vs long text)
mappum
committed
todo
Brian Tiger Chow
committed
feat(ipfs2/config) impl show and edit as options
Brian Tiger Chow
committed
add todo
Brian Tiger Chow
committed
cmds2/add: return correct error
jbenet
committed
cmds2/add: temp fix for -r. horrible hack
jbenet
committed
commands: Fixed value mutation bug in Request#SetOption
mappum
committed
commands: Cleanup Requests after command execution returns
mappum
committed
add logging file
jbenet
committed
cmds/add fixed add output
jbenet
committed
refactored cast errors to use a util
jbenet
committed
unused import fix
jbenet
committed
commands/http: Get string representations of option values when creating querystring
mappum
committed
feat(commands) add cast error
Brian Tiger Chow
committed
explain(commands/http)
Brian Tiger Chow
committed
refactor(commands/optionvalue) use
Brian Tiger Chow
committed
tests(commands/option) test the OptionValue methods
Brian Tiger Chow
committed
fix(commands/optionvalue) don't shadow the return variable
Brian Tiger Chow
committed
fix(commands/http/handler) check if found
Brian Tiger Chow
committed
fix(commands/mount_unix, optionvalue) handle found, !found
Brian Tiger Chow
committed
fix(mount_unix) optionvalue signature
Brian Tiger Chow
committed
fix(2/pin) optionvalue signature
Brian Tiger Chow
committed
fix(2/refs) optionvalue signature
Brian Tiger Chow
committed
fix(2/version) option value sig
Brian Tiger Chow
committed
fix(2/init, 2/add) fix optionvalue signature
Brian Tiger Chow
committed
fix(2/main) option value signature
Brian Tiger Chow
committed
refactor(mount_unix) return the errs in select
Brian Tiger Chow
committed
rename variable
Brian Tiger Chow
committed
question(mount_unix) add todo regarding mount timeout
Brian Tiger Chow
committed
fix(commands/optionvalue) use the util.ErrCast()
Brian Tiger Chow
committed
docs(commands/request)
Brian Tiger Chow
committed
commands: Added HelpText struct to organize different help text fields in Commands
mappum
committed
commands/cli: Transitionary commit - Generate helptext from HelpText fields if they aren't empty
mappum
committed
newline in short helptext
jbenet
committed
cmds/main decomposed handleParseError
jbenet
committed
cmd/ipfs: Fixed bug where handleParseError sets error to nil
mappum
committed
commands/cli: Less line breaks in autogenerated formatting
mappum
committed
fix(2/bootstrap) catch hidden panic
Brian Tiger Chow
committed
cmds/helptext: indent + newlines + synopsis
jbenet
committed
cmds/config: better help text
jbenet
committed
commands/cli: Fixed spacing error
mappum
committed
cmds2/helptext moved indent + tagline in subcmd
jbenet
committed
cmd2 align arguments properly
jbenet
committed
cmd2 bootstrapCmd missing type
jbenet
committed
cmds2: errHelpRequested error
jbenet
committed
cmds2 config outputs nicely
jbenet
committed
fix(ipfs2) output info to logger when checking daemon status
Brian Tiger Chow
committed
docs(ipfs2/main)
Brian Tiger Chow
committed

Commits on Nov 13, 2014

Commits on Nov 14, 2014

fix(tour) patch up and verify tour output
Brian Tiger Chow
committed
don't use the marshaler
Brian Tiger Chow
committed
s/number/id "the id of the topic you'd like to tour"
Brian Tiger Chow
committed
rm unused tests
Brian Tiger Chow
committed
rm todos
Brian Tiger Chow
committed
fix(2/version)
Brian Tiger Chow
committed
cmds2: name synopsis.
jbenet
committed
cmds2: add fix, was not adding dirs
jbenet
committed
cmd2: version test
jbenet
committed
add string method to command details
Brian Tiger Chow
committed
cmds2: use cmdDetails on level cmds
jbenet
committed
ignore binary
Brian Tiger Chow
committed
fix(2/update) newlines
Brian Tiger Chow
committed
fix(2/update) insert line break
Brian Tiger Chow
committed
object: Added a synopsis
mappum
committed
object get: Fixed protobuf marshaling
mappum
committed
object put: Formatted helptext
mappum
committed
object put: Fixed putting objects with JSON encoding
mappum
committed
object put: Added plaintext marshaler
mappum
committed
object put: Made output (almost) match original output
mappum
committed
object data: Moved some helptext into LongDescription
mappum
committed
object links: Added text marshaling
mappum
committed
cmds2: mount exmplae
jbenet
committed
object links: Fixed description
mappum
committed
commands/http: Fixed client erroring on nil command output
mappum
committed
cmds2: change add arg name
jbenet
committed
commands/cli: Take an optional Stdin value in Parse (read as a reader argument or string argument)
mappum
committed
main: Pass Stdin to CLI request parser
mappum
committed
commands/cli: Fixed bug when parsing args for a command that doesn't have any argument definitions
mappum
committed
commands: Added a flag to enable stdin arguments
mappum
committed
block put: Support stdin input on 'block put'
mappum
committed
cmds2: check for updates
jbenet
committed
cmds: nicer error on no mountpoint
jbenet
committed