add context to DialPeer interface #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btc
force-pushed
the
context-dial-peer
branch
from
7a2805e
to
5f23c81
Compare
|
Guessing the previous comments are no invalidated? @maybebtc Do LGTM!! |
|
It's still important to pass the caller's context down to the leaves. Just infeasible at the moment. to merge after #271 |
jbenet
force-pushed
the
context-dial-peer
branch
from
2aebcfd
to
37bb8ae
Compare
| err := util.Do(ctx, func() error { | ||
| _, err := n.swarm.Dial(p) | ||
| return err | ||
| }) |
|
@maybebtc other than name LGTM |
added 7 commits
November 5, 2014 10:04
btc
force-pushed
the
context-dial-peer
branch
from
37bb8ae
to
40c5cca
Compare
|
fixed name |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
gx publish 4.4.27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whyrusleeping @jbenet CR
I added
context.Contextto theDialPeer(...)interface method to preserve bitswap's API contract (thatbitswap.GetBlockwill return when the parent cancels its context). To make this possible, I updated signatures throughout thenetandroutingpackages.Down in the swarm, discovered that
Swarm.Dialignores the caller's context and instead passes it's own into thenet.conn.Dialer.Since the function is being called in the context of the caller, the correct behavior is for swarm to pass the caller's context. Made this change in 7a2805e.@jbenet Are there any side effects to worry about?yesI was excited to follow these calls down the stack. The
netlayer is in pretty good shape, and will continue to improve as the system matures and we discover useful conventions for large-scale concurrent design.