Remove note about Go1.6 not being supported #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +57,8 @@ From there: | |||
|
|
|||
| #### Install Go | |||
|
|
|||
| First, you'll need Go. If you don't have it: [Download Go 1.5.2+](https://golang.org/dl/). **Go 1.6 is not yet supported.** | |||
| First, you'll need Go. If you don't have it: [Download Go 1.6.2+](https://golang.org/dl/). _Go 1.5 is still being supported._ | |||
There was a problem hiding this comment.
I'd phrase it something like:
Ipfs requires at least go 1.5 to build, but we strongly recommend using 1.6.2. If you don't have it....
There was a problem hiding this comment.
I will phrase it as:
Build process of ipfs requires at least Go 1.5, but we strongly recommend using 1.6.2. If you don't have it....
Just to not capitalize ipfs (small habit from cjdns).
Recommend Go1.6.2 Note that Go1.5 is still supported License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
feature/Go1.6IsSupported
branch
from
e54d609
to
b64cc93
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommend Go1.6.2
Note that Go1.5 is still supported
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch