Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations to gx #2825

Merged
merged 5 commits into from
Jun 9, 2016
Merged

Migrations to gx #2825

merged 5 commits into from
Jun 9, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Jun 8, 2016 •
edited
Loading

Part of #2722

@Kubuxu Kubuxu added the status/in-progress In progress label Jun 8, 2016
@Kubuxu Kubuxu force-pushed the feature/Godeps-to-gx-part-whatever branch from a99eb96 to d64c1d1 Compare June 8, 2016 18:14
@Kubuxu Kubuxu mentioned this pull request Jun 8, 2016
Closed
@Kubuxu Kubuxu force-pushed the feature/Godeps-to-gx-part-whatever branch from 483b512 to ec7d976 Compare June 8, 2016 19:16
@whyrusleeping
Copy link
Member

LGTM

@whyrusleeping
Copy link
Member

Let me know when you want to merge

@Kubuxu
Move go-humanize to gx
6d4975d 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Move atomicfile to gx
d5702d7 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Move goleveldb to gx
35cdc13 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Move go-sysinfo to gx
c7d04e9 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Move fsnotify to gx
fb0aa63 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu force-pushed the feature/Godeps-to-gx-part-whatever branch from 9a1a2a0 to fb0aa63 Compare June 9, 2016 09:32
@Kubuxu
Copy link
Member Author

Kubuxu commented Jun 9, 2016

@whyrusleeping it is good for merge now

@Kubuxu Kubuxu added need/review Needs a review and removed status/in-progress In progress labels Jun 9, 2016
@whyrusleeping whyrusleeping merged commit 9cb55b0 into master Jun 9, 2016
@whyrusleeping whyrusleeping deleted the feature/Godeps-to-gx-part-whatever branch June 9, 2016 21:32
@hoffmabc
Copy link

Hey this merge I think broke some stuff. Either that or I'm ignorant to how this works. Quite possible btw.

../go-ipfs/Godeps/_workspace/src/github.com/syndtr/goleveldb/leveldb/errors/errors.go:14:2: cannot find package "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/syndtr/goleveldb/leveldb/storage" in any of:
    /usr/local/opt/go/libexec/src/github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/syndtr/goleveldb/leveldb/storage (from $GOROOT)
    /Users/brianhoffman/golang/src/github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/syndtr/goleveldb/leveldb/storage (from $GOPATH)
../go-ipfs/Godeps/_workspace/src/github.com/syndtr/goleveldb/leveldb/errors/errors.go:15:2: cannot find package "github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/syndtr/goleveldb/leveldb/util" in any of:
    /usr/local/opt/go/libexec/src/github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/syndtr/goleveldb/leveldb/util (from $GOROOT)
    /Users/brianhoffman/golang/src/github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/syndtr/goleveldb/leveldb/util (from $GOPATH)

The only way I was able to remedy this was to install the goleveldb repo independently and remove those _workspace references in the imports.

@Kubuxu
Copy link
Member Author

Kubuxu commented Jun 10, 2016 •
edited
Loading

As you can see there is no goleveldb at all: https://github.com/ipfs/go-ipfs/tree/master/Godeps/_workspace/src/github.com/syndtr/

Make sure that you did good pull, no unchecked files and run make build or gx install.

Where do you have those files imported?

@whyrusleeping whyrusleeping mentioned this pull request Jun 10, 2016
Open
@hoffmabc
Copy link

This is coming from https://github.com/OpenBazaar/openbazaar-go

@whyrusleeping
Copy link
Member

@hoffmabc do you have some repro steps? I can definitely take a look at it.

We're in the middle of transitioning all the rest of our deps from godeps into gx so that we can avoid problems like this in the future.

@Kubuxu
Copy link
Member Author

Kubuxu commented Jun 10, 2016 •
edited
Loading

Looks like openbazaar vendors go-ipfs in https://github.com/OpenBazaar/openbazaar-go/tree/master/vendor/github.com/ipfs/go-ipfs it is possible that something got stale or not removed or something.

I've grep'ed go-ipfs codebase, there is no reference to old Godep'ed goleveldb anywhere.

@hoffmabc
Copy link

@cpacia could answer this better probably but there is a possibility of something lingering, but I completely cleaned my $GOPATH and started from scratch just doing

go get https://github.com/OpenBazaar/openbazaar-go

and this is what I got. I then proceeded to install go-ipfs and gx separately and still didn't improve.

@Kubuxu
Copy link
Member Author

Kubuxu commented Jun 10, 2016 •
edited
Loading

Ok, everything is explained now I think: https://github.com/OpenBazaar/openbazaar-go/blob/f62cbb590cb60bcce4f4dbe540f643c355385707/core/core.go

OpenBazaar uses vendored deps of go-ipfs directly, that dep was removed from place where OB references it.

@hoffmabc
Copy link

Ok gotcha thanks

@cpacia
Copy link

cpacia commented Jun 11, 2016

That was my ide autochaning the import on me :p

Also @hoffmabc we aren't working out of master. Just last releases.

hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@whyrusleeping
Merge pull request ipfs/kubo#2825 from ipfs/feature/Godeps-to-gx-part…
5de04bd 
…-whatever

Migrations to gx

This commit was moved from ipfs/kubo@9cb55b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need/review Needs a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kubuxu @whyrusleeping @hoffmabc @cpacia