Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DHT tests failing because of repeated addresses #2855

Merged
merged 1 commit into from
Jun 15, 2016

Commits on Jun 14, 2016

  1. Fix DHT tests failing because of repeated addresses

    Due to SO_REUSE_PORT it is possible for a localhost:0
    address to repeat. This causes failure in DHT tests
    where we spun up a lot of nodes inside test.
    
    As for a birthday paradox it is enough to use 140
    ports to get 20% chance for collision which was causing
    failure in our case.
    
    The fix is to disable REUSE_PORT routine for the
    tests and leave it running for sharness tests where
    not that many addresses are used at the same time.
    
    License: MIT
    Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    Kubuxu committed Jun 14, 2016
    Configuration menu
    Copy the full SHA
    32cdbbd View commit details
    Browse the repository at this point in the history